Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ListViewArray and LargeListViewArray implementation and layout and basic construction #5501

Open
Tracked by #5375
Kikkon opened this issue Mar 13, 2024 · 6 comments
Labels
enhancement Any new improvement worthy of a entry in the changelog

Comments

@Kikkon
Copy link
Contributor

Kikkon commented Mar 13, 2024

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

This is part of a larger project #5375

Describe the solution you'd like

@Kikkon Kikkon added the enhancement Any new improvement worthy of a entry in the changelog label Mar 13, 2024
@Kikkon
Copy link
Contributor Author

Kikkon commented Mar 24, 2024

Progress update: Currently in development. If everything goes smoothly, I will submit a pull request before this Friday.

@Kikkon
Copy link
Contributor Author

Kikkon commented Mar 31, 2024

Hi @alamb I have drafted a pull request #5576 , but I think it might need some modifications. It would be great if you could give some suggestions. 😇

@alamb
Copy link
Contributor

alamb commented Apr 1, 2024

Thanks @Kikkon -- I'll try and check it out later this week. It may be several days however as I am working on a bunch of other thing concurrently now as well

@Kikkon
Copy link
Contributor Author

Kikkon commented Jul 26, 2024

Hi @alamb , I might need your help. If you're available, could you assist in pushing forward the merging process of this PR? #5723

@alamb
Copy link
Contributor

alamb commented Jul 26, 2024

Hi @Kikkon -- I am very sorry about the delay. I am very backed up on reviews (I realize that #5723 has been hanging out for a long time).

Do you have some background on what you are trying to do with this feature (so I can try and find some other committers who might have bandwidth to help)?

@Kikkon
Copy link
Contributor Author

Kikkon commented Jul 27, 2024

Hi @alamb
PR #5723 is part of addressing issue #5501, aiming to enhance support for the ListView type in arrow-rs by add GenericListViewArray. Previously, PR #5664 introduced the basic data structure and validation. Once #5723 is merged, we will proceed with adding GenericListViewBuilder and the corresponding ArrayData equality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
2 participants