Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport] Deprecate implicit default DAG schedule #41469

Merged
merged 2 commits into from
Aug 20, 2024
Merged

[Backport] Deprecate implicit default DAG schedule #41469

merged 2 commits into from
Aug 20, 2024

Conversation

uranusjr
Copy link
Member

This backports #41321 to 2.10.

@boring-cyborg boring-cyborg bot added area:API Airflow's REST/HTTP API area:serialization provider:cncf-kubernetes Kubernetes provider related issues labels Aug 14, 2024
@uranusjr uranusjr added this to the Airflow 2.10.0 milestone Aug 14, 2024
@uranusjr uranusjr mentioned this pull request Aug 14, 2024
Merged
@potiuk potiuk closed this Aug 14, 2024
@potiuk potiuk reopened this Aug 14, 2024
@potiuk
Copy link
Member

potiuk commented Aug 14, 2024

I think you need to rebase it now @uranusjr to trigger tests after #41476 has been cherry-picked to v2-10-test

@uranusjr uranusjr force-pushed the deprecate-missing-schedule-2-10 branch from a389262 to d924825 Compare August 14, 2024 13:18
@potiuk
Copy link
Member

potiuk commented Aug 14, 2024

Yeah. Some small fixes are still needed as expected #41478 and #41480 - likely some cache speedup will be needed as well

@potiuk
Copy link
Member

potiuk commented Aug 14, 2024

Ok. Try to rebase and see if it will work now @uranusjr

@uranusjr uranusjr force-pushed the deprecate-missing-schedule-2-10 branch from d924825 to 256f753 Compare August 15, 2024 00:02
@uranusjr @potiuk
Deprecate implicit default DAG schedule (apache#41321)
3656486 
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
@uranusjr uranusjr force-pushed the deprecate-missing-schedule-2-10 branch from 256f753 to 5048cfb Compare August 15, 2024 00:02
@uranusjr uranusjr force-pushed the deprecate-missing-schedule-2-10 branch from 5048cfb to 3c3df60 Compare August 15, 2024 00:56
@uranusjr uranusjr marked this pull request as ready for review August 15, 2024 01:48
kaxil
kaxil approved these changes Aug 16, 2024
View reviewed changes
Copy link
Member

@kaxil kaxil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a newsfragment ?? so maybe we can have a deprecated section in 2.10.1 or 2.11 docs

@kaxil kaxil modified the milestones: Airflow 2.11.0, Airflow 2.10.1 Aug 16, 2024
@uranusjr uranusjr merged commit a9c7d1a into apache:v2-10-test Aug 20, 2024
70 checks passed
@uranusjr uranusjr deleted the deprecate-missing-schedule-2-10 branch August 20, 2024 03:58
@utkarsharma2 utkarsharma2 added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Aug 30, 2024
utkarsharma2 pushed a commit that referenced this pull request Sep 2, 2024
@uranusjr @potiuk @utkarsharma2
[Backport] Deprecate implicit default DAG schedule (#41469)
9a32f7d 
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaxil kaxil kaxil approved these changes

@vincbeck vincbeck vincbeck approved these changes

@jedcunningham jedcunningham Awaiting requested review from jedcunningham jedcunningham is a code owner

@ephraimbuddy ephraimbuddy Awaiting requested review from ephraimbuddy ephraimbuddy is a code owner

@dstandish dstandish Awaiting requested review from dstandish dstandish is a code owner

@eladkal eladkal Awaiting requested review from eladkal eladkal is a code owner

@mobuchowski mobuchowski Awaiting requested review from mobuchowski mobuchowski is a code owner

@o-nikolas o-nikolas Awaiting requested review from o-nikolas o-nikolas is a code owner

@ashb ashb Awaiting requested review from ashb ashb is a code owner

@bolkedebruin bolkedebruin Awaiting requested review from bolkedebruin bolkedebruin is a code owner

@XD-DENG XD-DENG Awaiting requested review from XD-DENG XD-DENG is a code owner

Assignees
No one assigned
Labels
area:API Airflow's REST/HTTP API area:serialization changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) provider:cncf-kubernetes Kubernetes provider related issues
Projects
None yet
Milestone
Airflow 2.10.1
Development

Successfully merging this pull request may close these issues.
6 participants
@uranusjr @potiuk @kaxil @vincbeck @ephraimbuddy @utkarsharma2