Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datasets UI Improvements #40871

Merged
merged 3 commits into from
Jul 24, 2024
Merged

Datasets UI Improvements #40871

merged 3 commits into from
Jul 24, 2024

Conversation

bbovenzi
Copy link
Contributor

@bbovenzi bbovenzi commented Jul 18, 2024

In anticipation of Dataset Aliases, the Datasets page is getting a refresh. What really matters are events, so this update allows us to emphasize Dataset Events and sets us up to show more event details in the future.

Most notably,

  • add a Dataset Events list to show all dataset events across all datasets
  • the dataset events was changed from a table to a list of cards with more richly displayed information (source, downstream runs, extra)
  • show dataset events, details, datasets list and the graph in separate tabs vs trying to squeeze everything into one view
  • new breadcrumb to show if a dataset is selected (later on we will allow users to select dataset events)
  • Richer dataset details (extra, consuming dags, producing tasks)
Screenshot 2024-07-23 at 1 59 19 PM Screenshot 2024-07-18 at 1 52 59 PM Screenshot 2024-07-18 at 1 53 09 PM Screenshot 2024-07-23 at 1 59 53 PM

DAG details also using the new dataset event cards:
Screenshot 2024-07-23 at 2 00 07 PM


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@bbovenzi bbovenzi added this to the Airflow 2.10.0 milestone Jul 18, 2024
@boring-cyborg boring-cyborg bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Jul 18, 2024
@bbovenzi bbovenzi added the area:datasets Issues related to the datasets feature label Jul 18, 2024
@vatsrahul1001
Copy link
Collaborator

@bbovenzi can we have a scroll in the list of cards showing dataset events extra? Also spacing between source and extras increases as we increase num of extra

Screen.Recording.2024-07-22.at.4.31.08.PM.mov

@vatsrahul1001
Copy link
Collaborator

@bbovenzi is it possible to provide DAG run id link in source and triggered
image

Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inspected code - unfortunately I am not to deep into React code and in Datasets... but did a manual check, looks like working as expected.

@bbovenzi
Copy link
Contributor Author

@bbovenzi can we have a scroll in the list of cards showing dataset events extra? Also spacing between source and extras increases as we increase num of extra

Screen.Recording.2024-07-22.at.4.31.08.PM.mov

Ok I have a follow up branch for a event details page. Perhaps we should only show extra then. Otherwise each card can be wildly different heights

@bbovenzi
Copy link
Contributor Author

@vatsrahul1001

I added links to datasets, dagruns and task instances. Also, we're now using the same card component in the DAG details.

I switched the extra fields to render as json, it starts as collapsed but will scroll if it exceeds 300px

@vatsrahul1001
Copy link
Collaborator

@bbovenzi looked good to me

@bbovenzi bbovenzi merged commit 25e1cf1 into apache:main Jul 24, 2024
48 checks passed
@bbovenzi bbovenzi deleted the dataset-event-ux branch July 24, 2024 12:16
@ephraimbuddy ephraimbuddy added the type:improvement Changelog: Improvements label Jul 25, 2024
molcay pushed a commit to VladaZakharova/airflow that referenced this pull request Aug 19, 2024
* Update Datasets page UX

* Cleanup selected dataset event code

* Use DatasetEventCard everywhere, use RenderedJson for extra, add links
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:datasets Issues related to the datasets feature area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues type:improvement Changelog: Improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants