Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support rendering ObjectStoragePath value #40638

Merged
merged 6 commits into from
Jul 18, 2024

Conversation

gyli
Copy link
Contributor

@gyli gyli commented Jul 7, 2024

Closes: #40361

Support jinja variable to be rendered in ObjectStoragePath as an operator argument.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Copy link

boring-cyborg bot commented Jul 7, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@potiuk
Copy link
Member

potiuk commented Jul 9, 2024

Could you please add a unit test covering it?

@eladkal eladkal added this to the Airflow 2.10.0 milestone Jul 13, 2024
@eladkal eladkal added the type:improvement Changelog: Improvements label Jul 13, 2024
@gyli
Copy link
Contributor Author

gyli commented Jul 13, 2024

@potiuk Test added. Please review again.

@gyli
Copy link
Contributor Author

gyli commented Jul 18, 2024

Hi @eladkal could you plz review?

@potiuk potiuk merged commit f88fdba into apache:main Jul 18, 2024
52 checks passed
Copy link

boring-cyborg bot commented Jul 18, 2024

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@fritz-astronomer
Copy link
Contributor

Awesome! Thanks @gyli ! Excited for this

romsharon98 pushed a commit to romsharon98/airflow that referenced this pull request Jul 26, 2024
]

---------

Co-authored-by: Young Li <gyli@uber.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:improvement Changelog: Improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ObjectStoragePath should be template-able
4 participants