Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use sentinel to mark dag as removed on reserialization #39825

Merged
merged 5 commits into from
Jul 10, 2024
Merged

Use sentinel to mark dag as removed on reserialization #39825

merged 5 commits into from
Jul 10, 2024

Commits on Jul 8, 2024

  1. Use sentinel to elide the dag object on reserialization 

    We don't serialize the dag on the task.dag attr when making RPC calls.  By marking it with a sentinel value, we can add understand when we're dealing with a deserialized object, and then re-set the dag attr while skipping some of the extra code applied in the setter.
    @dstandish
    dstandish committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    40566ca View commit details
    Browse the repository at this point in the history

  2. fix test

    @dstandish
    dstandish committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    d381342 View commit details
    Browse the repository at this point in the history

  3. try again

    @dstandish
    dstandish committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    4ed84b7 View commit details
    Browse the repository at this point in the history

  4. fix tests

    @dstandish
    dstandish committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    4aa024e View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2024

  1. change name to ATTRIBUTE_REMOVED

    @dstandish
    dstandish committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    2486ec0 View commit details
    Browse the repository at this point in the history