-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#38284] Update Confirmation Logic for Config Changes on Sensitive Environments Like Production #38299
Conversation
…Sensitive Environments Like Production
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good.
Here is the static checks doc you need to fix the failed tests.
@hussein-awala I've fixed the static check issue. Thank you for your advice. |
This reverts commit cccfeb7.
@potiuk sorry for taking your time. I'm fixed the ruff check. Please approve trigger the workflow to run test. 🙆♂️ |
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
Congrats on your first commit 🎉 |
…ive Environments Like Production (apache#38299) * - [apache#38284] Update Confirmation Logic for Dag status Changes on Sensitive Environments Like Production * - Update pause/unpause confirm messages * - Not version added yet * - Fix static check * - Ruff check * Revert "- Fix static check" This reverts commit cccfeb7. * - Fix ruff check
May I suggest that this be added to |
|
Description
I've added a configuration option
require_confirmation_dag_change
to both theconfig.yml
and the Flask App. Its default value isFalse
. However, when a user sets this configuration toTrue
, the Dag screen (Dag.html
) will enforce a logic that requires users to confirm before they can Trigger a DAG or Pause/UnPause a Dag.This feature is particularly effective for teams working across multiple environments, including sensitive ones like Production.
Note: The confirmation is similar to the confirmation box displayed when deleting a Dag.
Related issue:
Test Screen
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.