Use single source of truth for sensitive config items #31820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we had them defined both in constant and in config.yml. Now just config.yml This change does however cause config.yml to be loaded when the sensitive_config_values property is accessed.
dstandish
requested review from
ryanahamilton,
ashb,
bbovenzi and
pierrejeambrun
as code owners
ashb
reviewed
Jun 9, 2023
ah yes, at first glance i thought this property might have gotten loaded up every time airflow conf got loaded but, i think you're right it's only invoked via webserver / configuration view so i think performance of loading the yaml is non-issue |
jedcunningham
approved these changes
Jun 9, 2023
potiuk
pushed a commit
that referenced
this pull request
Jun 9, 2023
Previously we had them defined both in constant and in config.yml. Now just config.yml (cherry picked from commit cab342e)
62 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we had them defined both in constant and in config.yml.
Now just config.yml
This change does however cause config.yml to be loaded when the sensitive_config_values property is accessed.