Make BaseJobRunner a generic on the job class #31287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
the
area:Scheduler
|
AAAH. That explains it ! Love it :) |
potiuk
approved these changes
May 15, 2023
|
🤯 -> the typing system of Python has quite a few pretty gray and dark corners :) |
eladkal
pushed a commit
that referenced
this pull request
Jun 8, 2023
(cherry picked from commit 2b6462b)
eladkal
pushed a commit
that referenced
this pull request
Jun 9, 2023
(cherry picked from commit 2b6462b)
62 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out the original one was quite close, just need to account for the fact that the variable type needs to be bound of either Job, JobPydantic, or a union of the two (which is a different type technically!)