-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove upper bound limitation for pytest
#29086
Conversation
setup.py
Outdated
@@ -387,7 +387,7 @@ def write_version(filename: str = str(AIRFLOW_SOURCES_ROOT / "airflow" / "git_ve | |||
# It contains a number of potential breaking changes but none of them looks breaking our use | |||
# https://docs.pytest.org/en/latest/changelog.html#pytest-7-0-0-2022-02-03 | |||
# TODO: upgrade it and remove the limit | |||
"pytest~=6.0", | |||
"pytest~=7.2.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think if main idea remove upper bound limitations and better use pytest>=6.0
or pytest>=7.0
(if we intend to use features which added only in 7.0 branch)
Maybe it is not a case of pytest
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make sense, done
I have a look at the warning logs, It is very hard to find where actually it raised. But finally I found only one type of pytest-specific warning. When we won't expected any warnings in test case we use with pytest.warns(None):
... But we should: https://docs.pytest.org/en/latest/how-to/capture-warnings.html#additional-use-cases-of-warnings-in-tests with warnings.catch_warnings():
warnings.simplefilter("error")
... We should do this as follow up however I have a suspicion that recommended solution wouldn't work because pytest-capture-warnings suppress this errored-warning, see: #28590 (comment) |
pytest
yes of course, thanks for pointing |
(pending removal of rerun plugin upper-bound limit of course) |
ok will do that |
Also need remove redundant comments that we need to migrate. |
ok will clear the comments as well |
done with review comments |
Non relevant error in the CI to this PR. Looks like internal_api test flaky if not ignore_running:
raise AssertionError(
> "Background processes are running that prevent the test from passing successfully."
)
E AssertionError: Background processes are running that prevent the test from passing successfully.
tests/cli/commands/test_internal_api_command.py:112: AssertionError |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
I think we can handle that in another PR? |
It definitely for another PR and related only to AIP-44, this flaky error also appeared in |
thank you both |
An attempt to update pytest version limit