Remove limit for dnspython after eventlet got fixed #29004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The eventlet/eventlet#782 fixed error that caused the need to limit dnspython and eventlet 0.33.3 has been released. We can now remove the limit for dnspython as long as we also limit eventlet to >=0.33.3.
potiuk
requested review from
ashb,
eladkal,
ephraimbuddy,
pierrejeambrun and
uranusjr
uranusjr
approved these changes
Jan 18, 2023
|
As result of our issue, eventlet has been fixed in eventlet/eventlet#782 and 0.33.3 release of eventlet @pierrejeambrun @ephraimbuddy - once we merge this one we should cherry-pick this one to RC2 adding to the RC2 changes as it is a better fix now once eventlet 0.33.3 is released (on top of fixing my fat-fingers spelling mistakes in rc2 PR of course). |
|
Random failure. Seems all is good. Merging. |
ephraimbuddy
added
the
changelog:skip
ephraimbuddy
pushed a commit
that referenced
this pull request
Jan 18, 2023
The eventlet/eventlet#782 fixed error that caused the need to limit dnspython and eventlet 0.33.3 has been released. We can now remove the limit for dnspython as long as we also limit eventlet to >=0.33.3. (cherry picked from commit eaf5675)
ephraimbuddy
added
type:misc/internal
86 tasks
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The eventlet/eventlet#782 fixed error that caused the need to limit dnspython and eventlet 0.33.3 has been released. We can now remove the limit
for dnspython as long as we also limit eventlet to >=0.33.3.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.