-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable copying DagRun JSON to clipboard #27639
Conversation
Hello @bdsoha, Good idea, When copying a line, there is a green tick that appears for 5.5 seconds, this green tick is not inline and makes the formatting jump when you hover it, I find this weird. (it appears bellow the copied line) Seems similar to mac-s-g/react-json-view#241 but only when you already have copied something to the clipboard. Maybe that's just me, but I whish the green tick was on the same line. |
@pierrejeambrun Is there a reason why this specific package is being used? |
Probably because we added it almost 2 years ago back when the package was still being updated. |
@bbovenzi Could The Acknowledgments section states:
|
@pierrejeambrun @bbovenzi I added the copy functionality with the I added a screenshot in the description. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that looks like a good library we could update to after this PR.
Left one small change we need to make in order for linting to pass.
@bbovenzi Static checks passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work!
Enable copying
DagRun
JSON details to the clipboard.