Implement extra controls for SLAs #27557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jorricks
requested review from
ryanahamilton,
ashb and
bbovenzi
as code owners
|
That looks good to me as an interim solution (and UI-only improvement). @bbovenzi @ryanahamilton @ashb? |
potiuk
approved these changes
Nov 13, 2022
bbovenzi
approved these changes
Nov 14, 2022
bdsoha
reviewed
Nov 14, 2022
bdsoha
reviewed
Nov 14, 2022
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Nov 14, 2022
The apache#27557 was built before normalizatin was applied and merging it caused static checks to fail.
potiuk
added a commit
that referenced
this pull request
Nov 14, 2022
The #27557 was built before normalizatin was applied and merging it caused static checks to fail.
|
#27662 merged |
bdsoha
added a commit
to bdsoha/airflow
that referenced
this pull request
Nov 14, 2022
ephraimbuddy
added
type:improvement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While there is a new effort for SLAs to be completely rewritten, I think it's good to spend a little time to make the current situation a bit more usable.
We sometimes face cases were our SLA notifications fail, and we'd have 100+ notifications waiting. These waiting never really make it through for some reason.
Therefore, we'd like to manually set them to success.
I figured these options are a low-effort solution to making the current solution more workable.
I considered creating tests, but saw that hardly any of the other actions really had tests and considered this to be so trivial that it doesn't need it.
Furthermore, with the move from FAB to React, this code won't last long anyway.