Resolve trigger assignment race condition #27072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavansharma36
force-pushed
the
bugfix/27057
branch
from
1397966
to
d9ccf03
Compare
pavansharma36
changed the title
dstandish
reviewed
Oct 15, 2022
dstandish
changed the title
|
Found util to add row locks by configuration or if dialect supports, updated with that change. |
|
cool 👍 looks like you maybe need to get your pre-commit hooks working locally... the formatting looks a little funky, but let's see what tests say |
|
I re-based it to account for failed image build. And it looks good in general. |
potiuk
approved these changes
Oct 24, 2022
uranusjr
reviewed
Oct 24, 2022
| skip_locked=True, | ||
| ).all() | ||
| if trigger_ids_query: | ||
| session.query(cls).filter(cls.id.in_([i.id for i in trigger_ids_query])).update( |
There was a problem hiding this comment.
Would it be possible to transform trigger_ids_query to a subquery so this can be done in one db call instead of two?
There was a problem hiding this comment.
@uranusjr As discussed update with limit is not supported, and adding subquery on same table is not supported in mysql
potiuk
approved these changes
Oct 31, 2022
|
Awesome work, congrats on your first merged pull request! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #27057
Added for update to avoid race condition between mutiple triggerer process
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.