-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix xcom arg.py .zip bug #26636
Fix xcom arg.py .zip bug #26636
Conversation
b66c62e
to
ec272af
Compare
ec272af
to
ebff0dd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving this, although I still want to know exactly which check exactly causes the issue. Would you be interested in help test this? (Basically change the checks one by one and see which ones make a difference.)
Sure. I would be happy to do that. End of the day here and work tomorrow, so it may take a little while. However, I will work on it. |
Thanks a lot! Since the apparent issue would be fixed with this PR, the specific root cause can be looked into without breaking things, so there’s no hurry, feel free to do it when you have time. |
Sounds good. Glad to help. Airflow is a great project. i’m hoping to learn and do more here. |
👀 |
Awesome work, congrats on your first merged pull request! |
(cherry picked from commit f219bfb)
(cherry picked from commit f219bfb)
Modified xcom_arg.py to test against ArgNotSet type, rather than an instance (NOTSET).
Fixes the filling of the _ZipResult with an erroneous fill value, when zip is called with the
default fillvalue=NOTSET.
closes: #26499
related: #26499