-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix grid view log try numbers #26556
Conversation
cc: @pierrejeambrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -99,12 +98,13 @@ const Logs = ({ | |||
tryNumber, | |||
}: Props) => { | |||
const [internalIndexes, externalIndexes] = getLinkIndexes(tryNumber); | |||
const [selectedAttempt, setSelectedAttempt] = useState(1); | |||
const [manuallySelectedAttempt, setSelectedAttempt] = useState<number | undefined>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Should we rename also the setter ? (Not a big fan of having the state and its setter with different names)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I decided to remove all use of "attempt" and use selectedTryNumber
and taskTryNumber
instead.
* redo how try numbers are displayed in grid view logs * rename attempt -> tryNumber (cherry picked from commit 6a69ad0)
* redo how try numbers are displayed in grid view logs * rename attempt -> tryNumber (cherry picked from commit 6a69ad0)
The try numbers shown in the grid view logs were showing an extra count and just not consistent with how the regular logs page works.
Fixes #26194 (comment)
Other fixes:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.