Attempt to create k8s venv without constraints if constraint build fails #26407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is an issue with trying to install the k8s env where the current requirements conflict with constraints. The k8s env creation is failing in this case. This PR will not fail hard when the constraint-build fails, instead it will attempt to build the venv without constraints. This will work in vast majority of cases.
|
This one is needed in order to make changes like #26393 to pass the k8s tests. The #26393 change adds FAB version bump - so that they are conflicting with the current constraints. And this causes k8s test venv failing to be created (because of conflicting requirements). The change attempts to run "no-constraints" k8s venv preparation after the "constraints" one fails. |
Merged
jedcunningham
approved these changes
Sep 14, 2022
potiuk
deleted the
fix-setup-k8s-venv-with-constraints-conflicting-with-setup
branch
ephraimbuddy
added
the
changelog:skip
ephraimbuddy
pushed a commit
that referenced
this pull request
Nov 10, 2022
…ils (#26407) There is an issue with trying to install the k8s env where the current requirements conflict with constraints. The k8s env creation is failing in this case. This PR will not fail hard when the constraint-build fails, instead it will attempt to build the venv without constraints. This will work in vast majority of cases. (cherry picked from commit 6f390fa)
ephraimbuddy
pushed a commit
that referenced
this pull request
Nov 10, 2022
…ils (#26407) There is an issue with trying to install the k8s env where the current requirements conflict with constraints. The k8s env creation is failing in this case. This PR will not fail hard when the constraint-build fails, instead it will attempt to build the venv without constraints. This will work in vast majority of cases. (cherry picked from commit 6f390fa)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an issue with trying to install the k8s env where the current requirements conflict with constraints. The k8s env creation is failing in this case.
This PR will not fail hard when the constraint-build fails, instead it will attempt to build the venv without constraints. This will work in vast majority of cases.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.