Add triggerer info to task instance in API #26249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:API
dstandish
force-pushed
the
add-triggerer-info-for-deferred-tasks
branch
from
ef4447b
to
54a7b37
Compare
uranusjr
approved these changes
Sep 12, 2022
|
Code makes sense to me. A few tests on the API and this should be good to go. |
dstandish
force-pushed
the
add-triggerer-info-for-deferred-tasks
branch
from
54a7b37
to
f5a35c8
Compare
dstandish
requested review from
ryanahamilton,
ashb,
bbovenzi,
mik-laj,
ephraimbuddy,
kaxil and
XD-DENG
as code owners
dstandish
changed the title
| innerjoin=True, | ||
| ) | ||
|
|
||
| trigger = relationship("Trigger", uselist=False) |
There was a problem hiding this comment.
Why don't we need innerjoin any longer?
There was a problem hiding this comment.
i don't think we ever needed it. not every TI has a trigger, so what happens is... when you reference this property in a query, the TIs that don't have a trigger drop out of the result set.
i looked, and it seems that there was only one usage of this attr, and in it, they actually overrided that setting, to set it to false...
jedcunningham
approved these changes
Sep 14, 2022
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
dstandish
force-pushed
the
add-triggerer-info-for-deferred-tasks
branch
from
7c0c0d9
to
5ba0be6
Compare
blag
approved these changes
Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Showing triggerer info in a section at the top of grid view TI details section
section will only be visible when ti state is deferred