Fix task policy example #25874
Closed
Fix task policy example #25874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no timeout parameter there is execution_timeout
potiuk
approved these changes
Aug 22, 2022
josh-fell
reviewed
Aug 22, 2022
| @@ -89,8 +89,8 @@ class TimedOperator(BaseOperator, ABC): | |||
| def task_policy(task: TimedOperator): | |||
| if task.task_type == 'HivePartitionSensor': | |||
| task.queue = "sensor_queue" | |||
| if task.timeout > timedelta(hours=48): | |||
There was a problem hiding this comment.
This is relative to the TimedOperator just above this policy though. The [START example_task_cluster_policy] marker was moved above the TimedOperator declaration in #23468 so it will show up in the Cluster Policy doc when published. Should the TimedOperator piece be removed altogether then?
There was a problem hiding this comment.
It seems complex to change the whole example. everything I touch produce another error.
I'll leave it to someone more experienced with cluster policy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no timeout parameter there is execution_timeout
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.