Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom_operator_name attr to _BranchPythonDecoratedOperator #25783

Merged
merged 1 commit into from
Aug 18, 2022

Conversation

josh-fell
Copy link
Contributor

Related: #22834

The @task.branch decorator snuck in while #22834 was being worked on. Adding a custom operator name for tasks using this decorator.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@josh-fell josh-fell changed the title Add custom_operator_name attr to _BranchPythonDecoratedOperator Add custom_operator_name attr to _BranchPythonDecoratedOperator Aug 18, 2022
Copy link
Contributor

@eladkal eladkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add pre-commit that verify all decorators have custom_operator_name ?

@uranusjr
Copy link
Member

Good idea, I’ll work on a separate PR for that.

@potiuk potiuk merged commit 648e224 into apache:main Aug 18, 2022
@josh-fell josh-fell deleted the branch-taskflow-deco-custom-op-name branch August 18, 2022 13:43
@ephraimbuddy ephraimbuddy added the type:misc/internal Changelog: Misc changes that should appear in change log label Sep 13, 2022
@ephraimbuddy ephraimbuddy added this to the Airflow 2.4.0 milestone Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:misc/internal Changelog: Misc changes that should appear in change log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants