Fail task if mapping upstream fails #25757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already mark the mapped task's unmapped ti to UPSTREAM_FAILED if the upstream fails with ALL_SUCCESS, so this simply replicates the behavior for all trigger rules.
boring-cyborg
bot
added
the
area:Scheduler
uranusjr
commented
Aug 17, 2022
| ).update({TaskInstance.state: TaskInstanceState.REMOVED}) | ||
|
|
||
| session.flush() | ||
| return all_expanded_tis, total_length | ||
| return all_expanded_tis, total_expanded_ti_count - 1 |
There was a problem hiding this comment.
I think the old code introduces an off-by-one error? The return value is described as “the maximum map_index” (and is used as such in BackfillJob), which should be one less than the total expand length, right?
There was a problem hiding this comment.
Yup.
def to_keep(key: TaskInstanceKey) -> bool:
if key.dag_id != node.dag_id or key.task_id != node.task_id or key.run_id != run_id:
# For another Dag/Task/Run -- don't remove
return True
return 0 <= key.map_index <= max_map_index
ashb
approved these changes
Aug 19, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already mark the mapped task's unmapped ti to UPSTREAM_FAILED if the upstream fails with ALL_SUCCESS, so this simply replicates the behavior for all trigger rules.
Fix #25698.