-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grid logs for mapped instances #25610
Grid logs for mapped instances #25610
Conversation
ab03fbd
to
58fd892
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. A few ideas:
- Let's move the mapped task table to its own tab so on a dynamic task summary you see
Details | Mapped Tasks (count)
- Let's add an extra "go back to dynamic task summary" button. you can use the breadcrumb but not everyone always realizes that
- let's remove the link buttons from the mapped task table and put that in the mapped task details page like how a normal task instance works. we can then replace that space in the table with a "direct to mapped task logs" button
I'm happy to help pull some of this apart so we can simplify the task instance component.
58fd892
to
6d00d53
Compare
870236c
to
bdff250
Compare
I updated the PR and the description.
|
Since we store the map_index in the url, we need to make sure we load an individual mapped task instance details. Also, a task instance might not have logs (ie: it is scheduled but hasn't run yet). We should handle that case instead of just showing a blank page to a user. Have you tested this with auto-refresh on? I don't think the mapped instance details are updating. |
airflow/www/static/js/dag/details/taskInstance/BackToTaskSummary.tsx
Outdated
Show resolved
Hide resolved
I broke that in my last commit 🤦... sorry for that. |
Maybe this is the source of some of the confusion. (I checked auto refresh for mapped task and tasks without logs, it's working now). |
Good idea that would indeed simplify things.
edit: This endpoint already exists |
e885db8
to
d715b43
Compare
airflow/www/static/js/dag/details/taskInstance/BackToTaskSummary.tsx
Outdated
Show resolved
Hide resolved
a2e1cd7
to
b7d0786
Compare
b7d0786
to
7fc2291
Compare
With your suggestions I was able to come up with a much simpler implementation, that I feel will be more robust as well. Thanks |
7fc2291
to
7948a6b
Compare
7948a6b
to
a3f6b8b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Thank you Brent :) |
#25568 added support for retrieving mapped instance task logs.
This PR adds support for displaying these logs in the Grid details side panel.
taskInstance
breadcrumbs becomes clickable in this particular case.Tested on:
See More
andDownload
links, and logs filters ✔️MappedInstances
Table ✔️SequentialExecutor
but the calls seems fine. (I didn't modify that part)Also fixes: #25616