Sync up plugin API schema and definition #25524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many of the entries should have been objects (dicts), not strings. Also removed "number" since it is not present anyway and I don't even know where it came from.
uranusjr
requested review from
ryanahamilton,
ashb,
bbovenzi,
mik-laj and
ephraimbuddy
as code owners
boring-cyborg
bot
added
area:API
|
Is it worth adding a newsfragment about this? I guess although this is technically a breaking change, since this endpoint never worked (right?) it's okay to change the API structure? |
|
The endpoint works as long as those values are not used (e.g. the setup has no custom views), but yes this is OK because whatever this “breaks” does not work right now. |
ashb
approved these changes
Aug 4, 2022
potiuk
approved these changes
Aug 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #25492. Many of the entries should have been objects (dicts), not strings. These have been defined like this ever since the API endpoint’s introduction in #14280.
I also removed
numbersince, as far as I can tell, it is not set or used anywhere in the code.We should probably add a bit more structure in those dicts, but this is the minimal change needed to make the schema make sense.