Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add and document description fields #25370

Merged
merged 3 commits into from
Aug 2, 2022

Conversation

norm
Copy link
Contributor

@norm norm commented Jul 28, 2022

Adds the description field to variables API calls, and documents that the connections API was already including it.

Closes #22007.

@boring-cyborg boring-cyborg bot added the area:API Airflow's REST/HTTP API label Jul 28, 2022
@potiuk
Copy link
Member

potiuk commented Jul 28, 2022

Tests are failing.

Variables can have descriptions, so that should be included in API results.
@ashb
Copy link
Member

ashb commented Aug 2, 2022

Looks like one of the generated files managed by pre-commit needs updating @norm airflow/www/static/js/types/api-generated.ts -- pre-commit run should make the changes for you locally then you only need to commit them

@potiuk potiuk merged commit 98f16aa into apache:main Aug 2, 2022
@eladkal eladkal added this to the Airflow 2.4.0 milestone Aug 2, 2022
@norm norm deleted the rest-api-descriptions branch August 3, 2022 04:40
@ephraimbuddy ephraimbuddy added the type:improvement Changelog: Improvements label Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:API Airflow's REST/HTTP API type:improvement Changelog: Improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Variable, Connection "description" fields available in the API
5 participants