Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove getTasks from Grid view #25359

Merged
merged 5 commits into from
Jul 28, 2022
Merged

Conversation

bbovenzi
Copy link
Contributor

@bbovenzi bbovenzi commented Jul 28, 2022

We were only using GET dags/{dag_id}/tasks for a few things in the grid view and there were two issues:

  • the request sometimes took multiple seconds for large dags
  • we weren't directly retrieving a task's operator, instead we relied on checking task.class_ref.class_name

By adding the operator info into grid_data, we can clean up a lot of code.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Jul 28, 2022
@bbovenzi bbovenzi merged commit a31b04c into apache:main Jul 28, 2022
@bbovenzi bbovenzi deleted the remove-getTasks branch July 28, 2022 12:06
@ephraimbuddy ephraimbuddy added the type:improvement Changelog: Improvements label Aug 15, 2022
@ephraimbuddy ephraimbuddy added this to the Airflow 2.4.0 milestone Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues type:improvement Changelog: Improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants