Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tutorial improvements. #25

Merged
merged 7 commits into from
Jun 15, 2015
Merged

Tutorial improvements. #25

merged 7 commits into from
Jun 15, 2015

Conversation

statwonk
Copy link
Contributor

Various suggested improvements to the tutorial for clarity.

@mistercrunch
Copy link
Member

"# variables t1, t2 and t3 are examples of tasks created by instantiating operators"

Also we should keep the file airflow/example_dags/tutorial.py in sync with this rst file

@statwonk
Copy link
Contributor Author

Thanks. :) The term constructor threw me for a loop, any ideas for being more explicit about that?

mistercrunch
mistercrunch reviewed Jun 14, 2015
View reviewed changes
docs/tutorial.rst
Tasks are generated when instantiating objects from operators. The first
argument ``task_id`` acts as a unique identifier for the task.
Tasks are generated when instantiating objects from operators. An object
instatiated from an operator is called a constructor. The first argument
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"constructor" is the name of the special method that define how the object is created. It's an OOP term, not specific to Airflow or anything.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, apologies, I'm coming from a FP background (R). :)

@mistercrunch
Copy link
Member

Apart from the confusion around constructor everything looks much better than it did before, thanks for taking the time.

nit: this whole PR probably should be a single commit (or 2 since there's comment history), note that you can --amend between pushes

@statwonk
Copy link
Contributor Author

Glad you think so! I'd really like to use AirFlow in production --- it fulfills an immediate need, so I'd like to contribute where I can. 10-4 on the verbose commits. I'll be sure to squash them before I submit next time.

@mistercrunch
Copy link
Member

img

mistercrunch added a commit that referenced this pull request Jun 15, 2015
@mistercrunch
Merge pull request #25 from statwonk/improve-tutorial
12b39d5 
Tutorial improvements.
@mistercrunch mistercrunch merged commit 12b39d5 into apache:master Jun 15, 2015
@statwonk statwonk deleted the improve-tutorial branch June 15, 2015 18:47
boralyl pushed a commit to upsight/airflow that referenced this pull request Apr 1, 2019
Merge pull request apache#25 in TP/incubator-airflow from feature/DAT…
3d00d47 
…A-3676 to develop

* commit '07783b64cef17cb4309c26c4230ee32f12cb6b4b':
  DATA-3676: bump version to 1.8.2-up1.15.0
  [AIRFLOW-1559] Add sqlalchemy engine disposal
aoen pushed a commit to aoen/incubator-airflow that referenced this pull request Dec 9, 2019
@rajatsri28 @msumit
[CX-16266] Change with reference to 1a4c164 commit in open source (ap…
67a4d1c 
…ache#25)

Due to refactoring of models.py in open source, made this changes instead of cherry picking the commit.
aoen pushed a commit to aoen/incubator-airflow that referenced this pull request Apr 10, 2020
@vshshjn7
[TWTR] CP from 1.10+twtr (apache#35)
299b4d8 
* 99ee040: CP from 1.10+twtr

* 2e01c24: CP from 1.10.4 ([TWTR][AIRFLOW-4939] Fixup use of fallback kwarg in conf.getint)

* 00cb4ae: [TWTR][AIRFLOW-XXXX] Cherry-pick d4a83bc and bump version (apache#21)

* CP 51b1aee: Relax version requiremets (apache#24)

* CP 67a4d1c: [CX-16266] Change with reference to 1a4c164 commit in open source (apache#25)

* CP 54bd095: [TWTR][CX-17516] Queue tasks already being handled by the executor (apache#26)

* CP 87fcc1c: [TWTR][CX-17516] Requeue tasks in the queued state (apache#27)

* CP 98a1ca9: [AIRFLOW-6625] Explicitly log using utf-8 encoding (apache#7247) (apache#31)

* fixing models.py and jobs.py file fix after CP

* fixing typo and version bump

Co-authored-by: Vishesh Jain <visheshj@twitter.com>
@srthok srthok mentioned this pull request Oct 6, 2020
Closed
This was referenced Oct 7, 2020
Closed
Closed
mobuchowski pushed a commit to mobuchowski/airflow that referenced this pull request Jan 4, 2022
@wslulciuc
Bump apache-airflow to 1.10.3 (apache#25)
8fcece1 
* Bump apache-airflow to 1.10.3

* Add airflow to requirements
mobuchowski pushed a commit to mobuchowski/airflow that referenced this pull request Jan 4, 2022
@julienledem
add support for format (apache#25)
e09e9e5 
Signed-off-by: Julien Le Dem <julien@apache.org>
rajatsri28 pushed a commit to rajatsri28/airflow that referenced this pull request Jan 25, 2022
@ayushSethi22
Airflow Upgrade with Cherry-Picks [only] from 1.10.4+twtr (apache#64)
d85a9a3 
* EWT-569 : Initial Commit for migrations

* [EWT-569] Airflow Upgrade to 1.10.14, Cherry-Pick  76fe7ac from 1.10.4

* CP Contains fb64f2e: [TWTR][AIRFLOW-XXX] Twitter Airflow Customizations + Fixup job scheduling without explicit_defaults_for_timestamp

* [EWT-569] Airflow Upgrade to 1.10.14, Cherry-Pick 91d2b00
[CP][EWT-548][AIRFLOW-6527] Make send_task_to_executor timeout configurable (apache#63)

* [EWT-569] Airflow Upgrade to 1.10.14, Cherry-Pick 91d2b00
CP contains [EWT-16]: Airflow fix for manual trigger during version upgrade (apache#13)

* [EWT-16]: Airflow fix for manual trigger during version upgrade

* [EWT-569] Airflow Upgrade to 1.10.14, Cherry-Pick 91d2b00
[CP][EWT-548][AIRFLOW-6527] Make send_task_to_executor timeout configurable (apache#63)

CP of f757a54

* CP(55bb579) [AIRFLOW-5597] Linkify urls in task instance log (apache#16)

* [EWT-569] Airflow Upgrade to 1.10.14 [CP] from 1.10.4+twtr : 94cdcf6
[CP] Contains [AIRFLOW-5597] Linkify urls in task instance log

CP of f757a54

* [EWT-569] Airflow Upgrade to 1.10.14, Cherry-Pick  4ce8d4c from 1.10.4
CP contains [TWTTR] Fix for rendering code on UI (apache#34)

* [EWT-569] Airflow Upgrade to 1.10.14, Cherry-Pick  299b4d8 from 1.10.4
CP contains [TWTR] CP from 1.10+twtr (apache#35)

* 99ee040: CP from 1.10+twtr

* 2e01c24: CP from 1.10.4 ([TWTR][AIRFLOW-4939] Fixup use of fallback kwarg in conf.getint)

* 00cb4ae: [TWTR][AIRFLOW-XXXX] Cherry-pick d4a83bc and bump version (apache#21)

* CP 51b1aee: Relax version requiremets (apache#24)

* CP 67a4d1c: [CX-16266] Change with reference to 1a4c164 commit in open source (apache#25)

* CP 54bd095: [TWTR][CX-17516] Queue tasks already being handled by the executor (apache#26)

* CP 87fcc1c: [TWTR][CX-17516] Requeue tasks in the queued state (apache#27)

* CP 98a1ca9: [AIRFLOW-6625] Explicitly log using utf-8 encoding (apache#7247) (apache#31)

* [EWT-569] Airflow Upgrade to 1.10.14 [CP] from 1.10.4+twtr : f7050fb
CP Contains Experiment API path fix (apache#37)

* [EWT-569] Airflow Upgrade to 1.10.14, Cherry-Pick  8a689af from 1.10.4
CP Contains Export scheduler env variable into worker pods. (apache#38)

* [EWT-569] Airflow Upgrade to 1.10.14, Cherry-Pick  5875a15 from 1.10.4
Cp Contains [EWT-115][EWT-118] Initialise dag var to None and fix for DagModel.fileloc (missed in EWT-16) (apache#39)

* [EWT-569] Airflow Upgrade to 1.10.14, Cherry-Pick  a68e2b3 from 1.10.4
[CX-16591] Fix regex to work with impersonated clusters like airflow_scheduler_ddavydov (apache#42)

* [EWT-569] Airflow Upgrade to 1.10.14 [CP] from 1.10.4+twtr : e9642c2
[CP][EWT-128] Fetch task logs from worker pods (19ac45a) (apache#43)

* [EWT-569] Airflow Upgrade to 1.10.14 [CP] from 1.10.4+twtr : d5d0a07
[CP][AIRFLOW-6561][EWT-290]: Adding priority class and default resource for worker pod. (apache#47)

* [EWT-569] Airflow Upgrade to 1.10.14 [CP] from 1.10.4+twtr : 9b58c88
[CP][EWT-302]Patch Pool.DEFAULT_POOL_NAME in BaseOperator (apache#8587) (apache#49)

Open source commit id: b37ce29

* [EWT-569] Airflow Upgrade to 1.10.14 [CP] from 1.10.4+twtr : 7b52a71
[CP][AIRFLOW-3121] Define closed property on StreamLogWriter (apache#3955) (apache#52)

CP of 2d5b8a5

* [EWT-361] Fix broken regex pattern for extracting dataflow job id (apache#51)

Update the dataflow URL regex as per AIRFLOW-9323

* [EWT-569] Airflow Upgrade to 1.10.14 [CP] from 1.10.4+twtr : 4b5b977
EWT-370: Use python3 to launch the dataflow job. (apache#53)

* [EWT-569] Airflow Upgrade to 1.10.14 [CP] from 1.10.4+twtr : 596e24f
* [EWT-450] fixing sla miss triggering duplicate alerts every minute (apache#56)

* [EWT-569] Airflow Upgrade to 1.10.14 [CP] from 1.10.4+twtr : b3d7fb4
[CP] Handle IntegrityErrors for trigger dagruns & add Stacktrace when DagFileProcessorManager gets killed (apache#57)

CP of faaf179 - from master
CP of 2102122 - from 1.10.12

* [EWT-569] Airflow Upgrade to 1.10.14 [CP] from 1.10.4+twtr : bac4acd
[TWTR][EWT-472] Add lifecycle support while launching worker pods (apache#59)

* [EWT-569] Airflow Upgrade to 1.10.14 [CP] from 1.10.4+twtr : 6162402
[TWTTR] Don't enqueue tasks again if already queued for K8sExecutor(apache#60)

Basically reverting commit 87fcc1c  and making changes specifically into the Celery Executor class only.

* [EWT-569] Airflow Upgrade to 1.10.14 [CP] from 1.10.4+twtr : 1991419
[CP][TWTR][EWT-377] Fix DagBag bug when a Dag has invalid schedule_interval (apache#61)

CP of 5605d10 & apache#11462

* [EWT-569] Airflow Upgrade to 1.10.14 [CP] from 1.10.4+twtr : 48be0f9
[TWTR][EWT-350] Reverting the last commit partially (apache#62)

* [EWT-569] Airflow Upgrade to 1.10.14 [CP] from 1.10.4+twtr : d8c473e
[CP][EWT-548][AIRFLOW-6527] Make send_task_to_executor timeout configurable (apache#63)

CP of f757a54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@statwonk @mistercrunch