Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort operator extra links #24992

Merged
merged 1 commit into from
Jul 12, 2022
Merged

Sort operator extra links #24992

merged 1 commit into from
Jul 12, 2022

Conversation

hterik
Copy link
Contributor

@hterik hterik commented Jul 12, 2022

Today, every time webserver is restarted, the order of the
operator extra links are randomized due to Python sets being
unordered.

This change will sort the links according to their name.
No particular thought has been given to customizing this sort
order, except to make it consistent so that extra links always
appear at the same place for the users.

Today, every time webserver is restarted, the order of the
operator extra links are randomized due to Python sets being
unordered.

This change will sort the links according to their name.
No particular thought has been given to customizing this sort
order, except to make it consistent so that extra links always
appear at the same place for the users.
@boring-cyborg boring-cyborg bot added the area:API Airflow's REST/HTTP API label Jul 12, 2022
Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very, very much agree.

@kaxil kaxil merged commit f5cd2c3 into apache:main Jul 12, 2022
@ephraimbuddy ephraimbuddy added the type:misc/internal Changelog: Misc changes that should appear in change log label Aug 12, 2022
@ephraimbuddy ephraimbuddy added this to the Airflow 2.3.4 milestone Aug 12, 2022
ephraimbuddy pushed a commit that referenced this pull request Aug 15, 2022
Today, every time webserver is restarted, the order of the
operator extra links are randomized due to Python sets being
unordered.

This change will sort the links according to their name.
No particular thought has been given to customizing this sort
order, except to make it consistent so that extra links always
appear at the same place for the users.

(cherry picked from commit f5cd2c3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:API Airflow's REST/HTTP API type:misc/internal Changelog: Misc changes that should appear in change log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants