Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debounce status highlighting in Grid view #24710

Merged
merged 3 commits into from
Jun 28, 2022

Conversation

bbovenzi
Copy link
Contributor

@bbovenzi bbovenzi commented Jun 28, 2022

Right now, any amount of hovering over a status in grid view will trigger highlighting. Instead, we should make sure the action is intentional by including a debounce with a 200ms delay.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragement file, named {pr_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Jun 28, 2022
@bbovenzi
Copy link
Contributor Author

CC: @pierrejeambrun

@bbovenzi bbovenzi added this to the Airflow 2.3.3 milestone Jun 28, 2022
@ashb
Copy link
Member

ashb commented Jun 28, 2022

How does it feel with a delay of 400ms? Did they number come from anywhere particular?

Copy link
Member

@ashb ashb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine - only question is if 400ms is too big or too small

@bbovenzi
Copy link
Contributor Author

bbovenzi commented Jun 28, 2022

Code looks fine - only question is if 400ms is too big or too small

It's the same delay we already have for Tooltips. Maybe we should make that a single variable across the app?

@pierrejeambrun
Copy link
Member

Nice improvement 👍

@bbovenzi
Copy link
Contributor Author

Actually, looks like we weren't consistent with our tooltip delays. I made a hoverDelay util variable to fix this.

@bbovenzi bbovenzi merged commit c7feb31 into apache:main Jun 28, 2022
@bbovenzi bbovenzi deleted the improve-grid-status-hover branch June 28, 2022 18:50
ephraimbuddy pushed a commit that referenced this pull request Jun 30, 2022
* Add delay / debounce to not always highlight tasks

* fix linting

* single delay variable at 200ms

(cherry picked from commit c7feb31)
@ephraimbuddy ephraimbuddy added the type:bug-fix Changelog: Bug Fixes label Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues type:bug-fix Changelog: Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants