Fix flaky order of returned dag runs #24405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
force-pushed
the
fix-flaky-order-of-dagruns
branch
from
c09f7b3
to
1646f3c
Compare
There was no ordering on a query returning dag_runs when it comes to grid view. This caused flaky tests but also it would have caused problems with random reordering of reported dagruns in the UI (it seems). This change adds stable ordering on returned Dag Runs: * by dag_run_id (ascending) asc No need to filter by map_index as there will be always max one returned TI from each dag run
potiuk
force-pushed
the
fix-flaky-order-of-dagruns
branch
from
1646f3c
to
57ca704
Compare
|
cc: @ashb -> I think you need to take a look, but I am quite certain it was it. |
malthe
approved these changes
Jun 13, 2022
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
okay to merge
ephraimbuddy
pushed a commit
that referenced
this pull request
Jun 29, 2022
There was no ordering on a query returning dag_runs when it comes to grid view. This caused flaky tests but also it would have caused problems with random reordering of reported dagruns in the UI (it seems). This change adds stable ordering on returned Dag Runs: * by dag_run_id (ascending) asc No need to filter by map_index as there will be always max one returned TI from each dag run (cherry picked from commit 2edab57)
ephraimbuddy
added
the
type:misc/internal
ephraimbuddy
added
type:bug-fix
This was referenced Jul 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was no ordering on a query returning dag_runs when it comes
to grid view. This caused flaky tests but also it would have
caused problems with random reordering of reported dagruns in the
UI (it seems).
This change adds stable ordering on returned Dag Runs:
No need to filter by map_index as there will be always max one
returned TI from each dag run
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragement file, named
{pr_number}.significant.rst, in newsfragments.