Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TI.log_url fix for map_index #24335

Merged
merged 6 commits into from
Jun 14, 2022
Merged

TI.log_url fix for map_index #24335

merged 6 commits into from
Jun 14, 2022

Conversation

fritz-astronomer
Copy link
Contributor

closes: #24328
related: #24328

Adds map_index to the task_instance.log_url link, which fixes a bug previously that prevented logs being displayed correctly at the link given.

@fritz-astronomer
Copy link
Contributor Author

Note - my local breeze tests may not have been working correctly. I had failures but mostly with tests/providers

@fritz-astronomer
Copy link
Contributor Author

This could definitely use some more unhappy-path tests. That required a slight overhaul to some of the pytest fixtures, so I didn't undertake it yet

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Jun 10, 2022
@github-actions
Copy link

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@fritz-astronomer
Copy link
Contributor Author

build failure appears to be unrelated to my code, release_notes.md misspelling - I cannot merge, so if anyone else wants to click the button (or let me know if I need to find time to make those unhappy path tests 😅 )

@potiuk potiuk merged commit 48a6155 into apache:main Jun 14, 2022
@potiuk
Copy link
Member

potiuk commented Jun 14, 2022

Merged @fritz-astronomer :) - it was indeed intermittent failure.

@ephraimbuddy ephraimbuddy added this to the Airflow 2.3.3 milestone Jun 29, 2022
ephraimbuddy pushed a commit that referenced this pull request Jun 29, 2022
(cherry picked from commit 48a6155)
@ephraimbuddy ephraimbuddy added the type:bug-fix Changelog: Bug Fixes label Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
full tests needed We need to run full set of tests for this PR to merge type:bug-fix Changelog: Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TI.log_url is incorrect with mapped tasks
6 participants