Use ti key lkp table for pre-migration dangling checks #23494
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstandish
force-pushed
the
use-ti-key-lkp-table
branch
2 times, most recently
from
0da6d28
to
db0d2e9
Compare
dstandish
force-pushed
the
use-ti-key-lkp-table
branch
from
db0d2e9
to
d4794a3
Compare
|
Don't need this one anymore. Performance already good enough with the switch to left join and other optimizations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #23491
Here I add a TI key lkp table for the “missing TI” lookups. This TI key table has one record for every valid TI key in the system. Its PK is dag id, task id, exec date. Lookups should be very fast. Locally on yesterday’s dataset, it takes under 30 seconds to do all the pre-migration checks.