Fix literal cross product expansion #23434
Conversation
github-actions
bot
added
the
full tests needed
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
| if total == 0: | ||
| total = len(value) | ||
| else: | ||
| total *= len(value) |
There was a problem hiding this comment.
I think we could have total = 1 at the beginning of the function instead…?
There was a problem hiding this comment.
I tried that, and that's how I found the .expand() bug. If we can assume we will always have at least something with a length, we could, but this felt more defensive.
There was a problem hiding this comment.
Let’s do this right now and maybe change it when we fix the expand bug. That way we can keep main working correctly.
jedcunningham
force-pushed
the
fix_cross_product_literal
branch
from
6c1b1df
to
8946e36
Compare
jedcunningham
force-pushed
the
fix_cross_product_literal
branch
from
8946e36
to
3be09f4
Compare
(cherry picked from commit 3fb8e0b)
(cherry picked from commit 3fb8e0b)
Closes: #23425
parse_time_mapped_ti_countwasn't taking into account the cross product behavior of expansion.