Fix broken task instance link in xcom list #23367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add execution date back to the xcom list to be able to pass to the `task_instance_link()` function. Long term, we should swap out the execution_date param for run_id
ashb
approved these changes
Apr 29, 2022
github-actions
bot
added
the
okay to merge
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
jedcunningham
pushed a commit
to astronomer/airflow
that referenced
this pull request
Apr 29, 2022
* Fix broken task instance link in xcom list Add execution date back to the xcom list to be able to pass to the `task_instance_link()` function. Long term, we should swap out the execution_date param for run_id * Make execution date a search column (cherry picked from commit 3920e60)
ephraimbuddy
pushed a commit
that referenced
this pull request
May 8, 2022
* Fix broken task instance link in xcom list Add execution date back to the xcom list to be able to pass to the `task_instance_link()` function. Long term, we should swap out the execution_date param for run_id * Make execution date a search column (cherry picked from commit 3920e60)
ephraimbuddy
pushed a commit
that referenced
this pull request
May 21, 2022
* Fix broken task instance link in xcom list Add execution date back to the xcom list to be able to pass to the `task_instance_link()` function. Long term, we should swap out the execution_date param for run_id * Make execution date a search column (cherry picked from commit 3920e60)
61 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: We removed
execution_datefrom the/xcomlist page. This caused the task id link to/taskto break because it could find a task but not the specific task instance.Fix: Add execution date back to the xcom list to be able to pass to the
task_instance_link()function.Eventually, we should swap out the execution_date param for run_id
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragement file, named
{pr_number}.significant.rst, in newsfragments.