Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

fix(plugin-chart-echarts): fix Timeseries tooltip title #956

Merged

Conversation

maloun96
Copy link
Contributor

Add format tooltip title as x axis

Close: apache/superset#13019

BEFORE

timeseries-before

AFTER

timeseries

@maloun96 maloun96 requested a review from a team as a code owner February 12, 2021 08:35
@vercel
Copy link

vercel bot commented Feb 12, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/gv7vnlfsr
✅ Preview: https://superset-ui-git-fork-maloun96-timeseries-title-tooltip-2.superset.vercel.app

@maloun96 maloun96 changed the title feat(plugin-chart-echarts) subject Timeseries tooltip title feat(plugin-chart-echarts): fix Timeseries tooltip title Feb 12, 2021
@maloun96 maloun96 changed the title feat(plugin-chart-echarts): fix Timeseries tooltip title fix(plugin-chart-echarts): fix Timeseries tooltip title Feb 12, 2021
@codecov
Copy link

codecov bot commented Feb 12, 2021

Codecov Report

Merging #956 (c5859b7) into master (59283de) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #956   +/-   ##
=======================================
  Coverage   27.68%   27.68%           
=======================================
  Files         401      401           
  Lines        8250     8250           
  Branches     1139     1139           
=======================================
  Hits         2284     2284           
  Misses       5830     5830           
  Partials      136      136           
Impacted Files Coverage Δ
...gin-chart-echarts/src/Timeseries/transformProps.ts 45.83% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59283de...c5859b7. Read the comment docs.

Copy link
Contributor

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah wonderful, I was annoyed by this just yesterday 👍

@villebro villebro merged commit 08dcf8f into apache-superset:master Feb 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[chart]x axis format is missing on the first date of each month
2 participants