chore: fix end-of-file #1468
chore: fix end-of-file #1468
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/superset/superset-ui/AEYzh6bo9S1qQZ1QQUhBHn33dD12 |
Codecov Report
@@ Coverage Diff @@
## master #1468 +/- ##
=======================================
Coverage 30.91% 30.91%
=======================================
Files 502 502
Lines 10220 10220
Branches 1762 1762
=======================================
Hits 3160 3160
Misses 6808 6808
Partials 252 252
Continue to review full report at Codecov.
|
|
LGTM |
| @@ -39,6 +39,38 @@ module.exports = { | |||
| extensions: ['.js', '.jsx', '.ts', '.tsx'], | |||
| }, | |||
| }, | |||
| // Allow core/src and core/test, not import modules from lib | |||
| 'import/internal-regex': /^@superset-ui\/core\/(src|test)/, | |||
There was a problem hiding this comment.
should this be 'import/internal-regex': /^@superset-ui\/([\w-]+)\/(src|test)/, to match all packages/plugins?
There was a problem hiding this comment.
I think we should avoid import packages like this:
@superset-ui/chart-controls/(src|test)/....
instead of
@superset-ui/chart-controls
🏠 Internal
Run ESLintbeforeBuild packages(in order to lint frontend file without build package).lintrc, make.lintrcconsistency of main repo'import/internal-regex'and'import/core-modules'into.lintrc(disallow import from /lib)test/enzymeintoplugins/plugin-chart-table/test/TableChart.test.tsxDEFAULT_FORM_DATA as TimeseriesDefaultFormDatafromplugin-chart-echarts"allowJs": falseinto parallel-coordinates tsconfig("allowJs": trueis default in main repo )