Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

fix: update chart sorting control labels/descriptions #1462

Merged
merged 1 commit into from
Nov 11, 2021

Conversation

john-bodley
Copy link
Contributor

🏠 Internal

See apache/superset#17383.

@john-bodley john-bodley requested a review from a team as a code owner November 9, 2021 19:03
@vercel
Copy link

vercel bot commented Nov 9, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/HJT2NFQkeDjc6wKRE15G9fbvwaKE
✅ Preview: https://superset-ui-git-john-bodley-update-control-desc-17b2b9-superset.vercel.app

Copy link
Contributor

@etr2460 etr2460 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stamping, but please rebase to make sure ci passes

@codecov
Copy link

codecov bot commented Nov 11, 2021

Codecov Report

Merging #1462 (0feb58c) into master (9e46f98) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1462   +/-   ##
=======================================
  Coverage   30.94%   30.94%           
=======================================
  Files         502      502           
  Lines       10212    10212           
  Branches     1760     1760           
=======================================
  Hits         3160     3160           
  Misses       6800     6800           
  Partials      252      252           
Impacted Files Coverage Δ
...chart-controls/src/shared-controls/dndControls.tsx 35.89% <ø> (ø)
...et-ui-chart-controls/src/shared-controls/index.tsx 35.71% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e46f98...0feb58c. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants