-
Notifications
You must be signed in to change notification settings - Fork 273
fix(plugin-chart-echarts): boxplot groupby incorrect #1448
fix(plugin-chart-echarts): boxplot groupby incorrect #1448
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/superset/superset-ui/J7AzB1dKjJA4e1zenzM8pkkgPoKu |
groupby: ensureIsArray(queryObject.groupby as QueryFormColumn[]), | ||
groupby: ensureIsArray(groupby), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
groupby
is deprecated on QueryObject
and is ambigous with columns
, hence we should use groupby
from formData
here, as it carries a specific meaning for the Boxplot chart.
808424a
to
109e7ea
Compare
109e7ea
to
f3927cb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## master #1448 +/- ##
==========================================
+ Coverage 30.43% 30.50% +0.07%
==========================================
Files 497 498 +1
Lines 10012 10024 +12
Branches 1691 1692 +1
==========================================
+ Hits 3047 3058 +11
- Misses 6719 6720 +1
Partials 246 246
Continue to review full report at Codecov.
|
🐛 Bug Fix
The post processing operation didn't include the groupby columns, resulting in NULL values on the x-axis. This PR fixes the bug, adds tests and adds type guards for all post processing rules.
Closes apache/superset#16951 , closes apache/superset#16985
AFTER
BEFORE