Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

chore(plugin-chart-echarts): bump echarts to 5.2.2 #1440

Merged
merged 2 commits into from
Nov 1, 2021

Conversation

villebro
Copy link
Contributor

@villebro villebro commented Oct 27, 2021

🐛 Bug Fix

Bump ECharts to 5.2.2 (changelog: https://dist.apache.org/repos/dist/dev/echarts/5.2.2-rc.1/RELEASE_NOTE.txt) which adds mouseover functionality to line/area charts. See how hovering now triggers the mouseover event, where previously only the marker triggered it. This will make the tooltip highlighting and cross-filtering more intuitive.

AFTER

echarts-5.2.2.mp4

BEFORE

echarts-5.2.1.mp4

@villebro villebro requested a review from a team as a code owner October 27, 2021 08:00
@vercel
Copy link

vercel bot commented Oct 27, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/BcDeehK2syLgjzBNEM9Gx3GnLvXW
✅ Preview: https://superset-ui-git-fork-preset-io-villebro-echarts-522-superset.vercel.app

@villebro villebro changed the title chore(plugin-chart-echarts): bump echarts to 5.2.2 [WIP] chore(plugin-chart-echarts): bump echarts to 5.2.2 Oct 27, 2021
@codecov
Copy link

codecov bot commented Oct 27, 2021

Codecov Report

Merging #1440 (cdde1a9) into master (02b7963) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1440   +/-   ##
=======================================
  Coverage   30.43%   30.43%           
=======================================
  Files         497      497           
  Lines       10012    10012           
  Branches     1691     1691           
=======================================
  Hits         3047     3047           
  Misses       6719     6719           
  Partials      246      246           
Impacted Files Coverage Δ
...chart-echarts/src/Timeseries/EchartsTimeseries.tsx 0.00% <0.00%> (ø)
...lugin-chart-echarts/src/Timeseries/transformers.ts 43.75% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02b7963...cdde1a9. Read the comment docs.

@villebro villebro changed the title [WIP] chore(plugin-chart-echarts): bump echarts to 5.2.2 chore(plugin-chart-echarts): bump echarts to 5.2.2 Nov 1, 2021
Copy link
Contributor

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@villebro villebro merged commit 6b8cda4 into apache-superset:master Nov 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants