-
Notifications
You must be signed in to change notification settings - Fork 273
feat(plugin-chart-echarts): add support for custom forecasts #1389
feat(plugin-chart-echarts): add support for custom forecasts #1389
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/superset/superset-ui/79mEzDz7q9hiKFjVpJ3Bd9AxJsrY |
380a3a5
to
adabd6e
Compare
adabd6e
to
f26c6f5
Compare
Codecov Report
@@ Coverage Diff @@
## master #1389 +/- ##
==========================================
+ Coverage 30.34% 30.41% +0.06%
==========================================
Files 497 497
Lines 9979 9990 +11
Branches 1680 1684 +4
==========================================
+ Hits 3028 3038 +10
- Misses 6706 6707 +1
Partials 245 245
Continue to review full report at Codecov.
|
Thank you, this fits our use-case we requested to allow us to create custom forecasts without Prophet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🏆 Enhancements
The need to be able to create custom forecasts (without Prophet) has come up. In order to make this possible, we will assume that a forecast is present if there is a series with the forecast suffix (
__yhat
,__yhat_lower
or__yhat_upper
).This is an intermediate step to decouple forecasts from Prophet - ultimately we should refactor the code in the following ways:
plugin-chart-echarts
tosuperset-ui/core
my_metric
could be accompanied bymy_metric__offset(PT1D)
which could then be shown in the legend (with translations) as "my metric (1 day time offset)" or similar.SCREENSHOTS
Notice, that I haven't enabled forecasting, yet I'm able to create a chart with a forecast and confidence interval by applying the necessary suffixes to the series names: