-
Notifications
You must be signed in to change notification settings - Fork 273
feat(plugin-chart-echarts): echarts funnel chart #1006
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/superset/superset-ui/ERWAfh3uY9n7unxmqiefvzRpMqkH |
Codecov Report
@@ Coverage Diff @@
## master #1006 +/- ##
==========================================
+ Coverage 27.80% 27.96% +0.16%
==========================================
Files 453 459 +6
Lines 9104 9169 +65
Branches 1416 1429 +13
==========================================
+ Hits 2531 2564 +33
- Misses 6381 6409 +28
- Partials 192 196 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! This looks good. Can't wait to see it in real action.
@xiezhongfu Thank you Zhongfu, for your contribution! Would you mind attaching a video? I can help you update the description accordingly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments. In addition to the recommendations posted here, I believe we should consider removing the last cone in the funnel: for a sales funnel starting at 100 and ending in 20 closed cases, the funnel now looks like this:
Here it looks like the last step goes to zero, when in fact the funnel closes culminates in a 20 % closing rate. I think it might be more intuitive to show the last step to start and end in 20, making it essentially a box. Alternatively the funnel could be changed so that it only consists of two trapezoids, and the labels would be "cold call -> follow-up meeting" and "follow-up meeting -> sale" or similar (maybe this could be a customization option).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code all looks good! There are several changes suggested by myself and others in controlPanel.tsx
that I think should be addressed. I'd be happy to help with those modifications, too!
Thank you for the awesome contribution.
Thank you. I try to solve the bug in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for your first contribution!
add funnel of echarts and the demo into plugin-chart-echarts
this is a link from funnel of
echarts.apache
: https://echarts.apache.org/examples/en/editor.html?c=funnelthis is a gif of funnel in superset