fix: horizon chart should scroll when overflowing

apache-superset · Aug 19, 2019 · 52dc2e3 · 52dc2e3
1 parent 8479099
commit 52dc2e3
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/packages/superset-ui-legacy-plugin-chart-horizon/src/HorizonChart.css b/packages/superset-ui-legacy-plugin-chart-horizon/src/HorizonChart.css
@@ -19,6 +19,7 @@
 
 .superset-legacy-chart-horizon {
   overflow: auto;
+  position: relative;
 }
 
 .superset-legacy-chart-horizon .horizon-row  {

diff --git a/packages/superset-ui-legacy-plugin-chart-horizon/src/HorizonChart.jsx b/packages/superset-ui-legacy-plugin-chart-horizon/src/HorizonChart.jsx
@@ -26,6 +26,7 @@ import './HorizonChart.css';
 const propTypes = {
   className: PropTypes.string,
   width: PropTypes.number,
+  height: PropTypes.number,
   seriesHeight: PropTypes.number,
   data: PropTypes.arrayOf(
     PropTypes.shape({
@@ -60,6 +61,7 @@ class HorizonChart extends React.PureComponent {
     const {
       className,
       width,
+      height,
       data,
       seriesHeight,
       bands,
@@ -75,8 +77,9 @@ class HorizonChart extends React.PureComponent {
       yDomain = d3Extent(allValues, d => d.y);
     }
 
+    console.log('SUPER', height);
     return (
-      <div className={`superset-legacy-chart-horizon ${className}`}>
+      <div className={`superset-legacy-chart-horizon ${className}`} style={{ height: height }}>
         {data.map(row => (
           <HorizonRow
             key={row.key}

diff --git a/packages/superset-ui-legacy-plugin-chart-horizon/src/transformProps.js b/packages/superset-ui-legacy-plugin-chart-horizon/src/transformProps.js
@@ -17,13 +17,14 @@
  * under the License.
  */
 export default function transformProps(chartProps) {
-  const { width, formData, payload } = chartProps;
+  const { height, width, formData, payload } = chartProps;
   const { horizonColorScale, seriesHeight } = formData;
 
   return {
     colorScale: horizonColorScale,
     data: payload.data,
     seriesHeight: parseInt(seriesHeight, 10),
     width,
+    height,
   };
 }