Update kube version in Windows helm charts #6497
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lan Luo <luola@vmware.com>
tnqn
reviewed
Jul 1, 2024
| @@ -5,7 +5,7 @@ displayName: Antrea | |||
| home: https://antrea.io/ | |||
| version: 0.0.0 | |||
| appVersion: latest | |||
| kubeVersion: ">= 1.22.0-0" | |||
| kubeVersion: ">= 1.19.0-0" | |||
There was a problem hiding this comment.
Was there any reason why it was set to >=1.22.0 in the first place?
There was a problem hiding this comment.
Good question, I checked the history and found out it's actually a specific requirement for Windows because of host process feature is supported since v1.122: #6360 (comment)
Let me close this PR. A following question is about the minimal K8s version for Antrea, should we update the v1.19 to v1.22 because of Windows?
There was a problem hiding this comment.
I think we should mention the minimal versions for linux and windows separately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the minimal K8s version to v1.19 to make it consistent with Linux charts.
Otherwise, it may lead following errors when the helm tool is built with default K8s version from client-go.