Export node latency query api define.

[IRONICBo]

We have collected all agents latencies in PR: #6120, then we need to export data to api server and report it to antrea controller.

In this PR, we try to define a REST api in antrea, and we will separate the REST api inner in other PR.

The commits base on PR #6120.

Design Doc: https://docs.google.com/document/d/1EdKJ8iQ3KwVBQAHaPisqHP7cgpq4RW8mD9KPWtYETbE/edit

[antoninbas]

Please resolve all build issues and make sure make golangci succeeds locally.

[Dyanngg]

There seems to be quite some import errors. Have you rebased the patch onto main?

[antoninbas]

There are still build issues that need to be addressed. It makes the PR harder to review. Once again, please make sure you can run make golangci successfully before pushing.

[antoninbas]

hmm I started a new round of review but it looks like some key comments haven't been addressed yet, so I will hold off on reviewing again.

[antoninbas]

Only a couple of small comments remaining from me.
@Dyanngg @tnqn do you want to take a look?

[tnqn]

Only a couple of small comments remaining from me.
@Dyanngg @tnqn do you want to take a look?

I could take a look tomorrow, could you wait for another day before merging it?

[antoninbas]

Only a couple of small comments remaining from me.
@Dyanngg @tnqn do you want to take a look?

I could take a look tomorrow, could you wait for another day before merging it?

Yes, no problem

[antoninbas]

LGTM

[tnqn]

I think it doesn't support delete and watch?

[antoninbas]

I asked @IRONICBo to include these verbs. I think we can add their implementation at the same time as the implementation for create, get and list, in the follow-up PR. But maybe we should include the 2 missing stubs in pkg/apiserver/registry/stats/nodelatencystats/rest.go as part of this PR.

[tnqn]

Yes, I wrote the comment because the server only supports create, get, and list, so had the impression they are the methods we are going to implement. Besides, do we need clients to delete a stats? and I remember supporting standard watch is somewhat difficult due to the resource version stuff.

[antoninbas]

Besides, do we need clients to delete a stats?

I think we may want Agents to delete their resource if the feature gets disabled. So IMO it makes sense to have delete.

I remember supporting standard watch is somewhat difficult due to the resource version stuff.

That makes sense. We should remove watch then.

@IRONICBo do you think you can:

1. remove watch from the list of verbs, and regenerate the code
2. add a stub Delete method in the REST server

[IRONICBo]

Ok, it sounds good to me.

[antoninbas]

@IRONICBo the PR will also need to be rebased, probably because I made some small changes to the monitor code when I added unit tests

[IRONICBo]

@IRONICBo the PR will also need to be rebased, probably because I made some small changes to the monitor code when I added unit tests

Ok, I have done.

[tnqn]

LGTM but pkg/agent/monitortool/monitor_test.go needs update

[IRONICBo]

LGTM but pkg/agent/monitortool/monitor_test.go needs update

Ok, I have add NewNodeLatencyMonitor params in monitor_test.go.

[antoninbas]

That won't work. You need a fake provider that will return the fake client when called. You can check out the test code in pkg/agent/controller/egress/egress_controller_test.go

[IRONICBo]

@antoninbas Ok, I configured gomock to generate the fake client and return the clientset using EXCEPT.

But in monitor.go->report() I need pkg/client/clientset/versioned/fake/clientset_generated.go, I need to use antrea's fakeclientset method to get the StatsV1alpha1().

Do I need to replace the clientset in k8s.io/client-go/kubernetes/fake used in test code?

clientset := fake.NewSimpleClientset(objects...)
statsClientset := statsfake.NewSimpleClientset(objects...)

[tnqn]

It's a bit overkill to generate a gomock implementation for that interface. You can just use a few lines to achieve it:

type antreaClientGetter struct {
	clientset versioned.Interface
}

func (g *antreaClientGetter) GetAntreaClient() (versioned.Interface, error) {
	return g.clientset, nil
}

antreaClientProvider := &antreaClientGetter{fakeversioned.NewSimpleClientset(objects...)}
m := NewNodeLatencyMonitor(antreaClientProvider, nodeInformer, nlmInformer, nodeConfig, trafficEncapMode)

You don't need to change other clientsets.

[IRONICBo]

Ok, that's helpful, I've updated it.

[tnqn]

LGTM

[antoninbas]

LGTM
@IRONICBo do you have time to work on the next PR (REST service implementation)?

[antoninbas]

/test-all

[IRONICBo]

do you have time to work on the next PR (REST service implementation)?

Yes, I'll go ahead and create the next part after this PR is merged.