Improve handling of config changes in FlowAggregator #6378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoninbas
added
area/flow-visibility/aggregator
yuntanghsu
previously approved these changes
May 28, 2024
| klog.InfoS("Updated RecordContents.PodLabels configuration", "value", fa.includePodLabels) | ||
| } | ||
| var unsupportedUpdates []string | ||
| if opt.Config.APIServer != fa.APIServer { |
There was a problem hiding this comment.
I think golang can check the contents in the struct (we only have int and string in APIServer)?
tnqn
previously approved these changes
May 29, 2024
| @@ -440,6 +441,35 @@ func TestFlowAggregator_updateFlowAggregator(t *testing.T) { | |||
| mockLogExporter.EXPECT().UpdateOptions(opt) | |||
| flowAggregator.updateFlowAggregator(opt) | |||
| }) | |||
| t.Run("includePodLables", func(t *testing.T) { | |||
There was a problem hiding this comment.
Suggested change
| t.Run("includePodLables", func(t *testing.T) { | |
| t.Run("includePodLabels", func(t *testing.T) { |
Prior to this change, only updates to the configuration of exporters (sinks) were handled gracefully, without requiring a FlowAggregator restart. After this change, we also support updating recordContents.podLabels at runtime. For all other unsupported config changes, we print an error log, asking users to restart the FlowAggregator. Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>
antoninbas
force-pushed
the
fa-improve-handling-of-unsupported-config-changes
branch
from
30c98b0
to
f24fea7
Compare
antoninbas
changed the title
antoninbas
added a commit
to antoninbas/antrea
that referenced
this pull request
May 30, 2024
This is a partial revert of antrea-io#6378. We cannot easily support live updates to recordContents.podLabels, as it requires re-creating the IPFIXExporter, so that a new IPFIX template set can be sent. Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, only updates to the configuration of exporters (sinks) were handled gracefully, without requiring a FlowAggregator restart.
After this change, we also support updating recordContents.podLabels at runtime.
For all other unsupported config changes, we print an error log, asking users to restart the FlowAggregator.