Fix unit test TestReconcile #5798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoninbas
reviewed
Dec 14, 2023
| ContainerID: generateUUID(t), | ||
| }, | ||
| } | ||
| unconnectedInterface := &interfacestore.InterfaceConfig{ |
There was a problem hiding this comment.
I guess this one is mostly useful for Windows testing?
There was a problem hiding this comment.
Yes, but it's also meaningful to validate linux does nothing for it.
| PodNamespace: testPodNamespace, | ||
| ContainerID: generateUUID(t), | ||
| }, | ||
| normalInterface := &interfacestore.InterfaceConfig{ |
There was a problem hiding this comment.
I didn't try to diff the interface definitions, but is there a significant difference between the Linux and Windows versions of the test interfaces, or could we use a shared definition in a common file?
There was a problem hiding this comment.
There should be no difference, I have moved them to common file.
cniServer.reconcile() now installs flows asynchorously. Signed-off-by: Quan Tian <qtian@vmware.com>
|
/skip-all |
tnqn
added a commit
to tnqn/antrea
that referenced
this pull request
Jan 8, 2024
cniServer.reconcile() now installs flows asynchorously. Signed-off-by: Quan Tian <qtian@vmware.com>
tnqn
added a commit
to tnqn/antrea
that referenced
this pull request
Jan 8, 2024
cniServer.reconcile() now installs flows asynchorously. Signed-off-by: Quan Tian <qtian@vmware.com>
tnqn
added a commit
that referenced
this pull request
Jan 10, 2024
cniServer.reconcile() now installs flows asynchorously. Signed-off-by: Quan Tian <qtian@vmware.com>
This was referenced Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cniServer.reconcile() now installs flows asynchorously.
Fixes #5796