Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename service related fields in Connection struct #5704

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

yuntanghsu
Copy link
Contributor

This PR is a follow-up PR for #5573 .
In this PR, we rename DestinationServiceAddress and DestinationServicePort for Connection struct as they actually represent the value of OriginalDestinationAddress and OriginalDestinationPort.
If these two values belong to a service traffic, we will fill them into destinationClusterIPv4/destinationClusterIPv6 and destinationServicePort before we export them from the Flow Exporter.

Copy link
Contributor

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antoninbas
Copy link
Contributor

@yuntanghsu please try to keep the commit title short, ideally git / Github should not have to truncate it

see https://cbea.ms/git-commit/ (link is from our CONTRIBUTING doc)

we rename DestinationServiceAddress and DestinationServicePort in Connection struct as
they actually represent the value of OriginalDestinationAddress and OriginalDestinationPort.

Signed-off-by: Yun-Tang Hsu <hsuy@vmware.com>
@yuntanghsu yuntanghsu changed the title Rename DestinationServiceAddress/DestinationServicePort to OriginalDestinationAddress/OriginalDestinationPort for Connection struct Rename service related fields in Connection struct Nov 14, 2023
Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tnqn
Copy link
Member

tnqn commented Nov 15, 2023

/skip-all

@tnqn tnqn merged commit dce23d6 into antrea-io:main Nov 15, 2023
49 of 56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants