Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix status report when no-op changes are applied to Antrea-native policies #5096

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

tnqn
Copy link
Member

@tnqn tnqn commented Jun 7, 2023

When no-op changes are applied to Antrea-native policies, such as adding or removing a non-existing group, there will be no datapath change but the generation has changed. The agent must report it has realized the latest generation even if it does nothing, otherwise the policy would stay realizing.

Fixes #5097

@tnqn tnqn added action/backport Indicates a PR that requires backports. action/release-note Indicates a PR that should be included in release notes. area/network-policy Issues or PRs related to network policies. labels Jun 7, 2023
…icies

When no-op changes are applied to Antrea-native policies, such as adding
or removing a non-existing group, there will be no datapath change but
the generation has changed. The agent must report it has realized the
latest generation even if it does nothing, otherwise the policy would
stay realizing.

Signed-off-by: Quan Tian <qtian@vmware.com>
@tnqn tnqn changed the title Fix status report when Antrea-native policies are made no-op change Fix status report when no-op changes are applied to Antrea-native policies Jun 7, 2023
@tnqn tnqn requested review from antoninbas and Dyanngg June 7, 2023 15:06
@tnqn
Copy link
Member Author

tnqn commented Jun 7, 2023

/test-all

Copy link
Contributor

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tnqn tnqn merged commit 8e7668c into antrea-io:main Jun 8, 2023
@tnqn tnqn deleted the fix-policy-status branch June 8, 2023 05:40
@tnqn tnqn added the kind/bug Categorizes issue or PR as related to a bug. label Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action/backport Indicates a PR that requires backports. action/release-note Indicates a PR that should be included in release notes. area/network-policy Issues or PRs related to network policies. kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Antrea-native policies stayed in realizing status in some cases
2 participants