Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid ServiceCIDR flapping on agent start #5017

Merged
merged 1 commit into from
May 23, 2023
Merged

Avoid ServiceCIDR flapping on agent start #5017

merged 1 commit into from
May 23, 2023

Commits on May 22, 2023

  1. Avoid ServiceCIDR flapping on agent start 

    The previous implementation always generated intermediate values for
ServiceCIDR on agent start, which may interrupt the Service traffic and
causes difficulty for cleaning up stale routes as the value calculated
at one point may not be reliable to identify all stale routes.

This commit waits for the Service Informer to be synced first,
and calculates the ServiceCIDR based on all Services. Ideally the
Service route won't change in most cases, and hence avoid the above
issues.

Besides, it fixes an issue that stale routes on Linux were not cleaned
up correctly due to incorrect check.

Signed-off-by: Quan Tian <qtian@vmware.com>
    @tnqn
    tnqn committed May 22, 2023
    Configuration menu
    Copy the full SHA
    741df1b View commit details
    Browse the repository at this point in the history