Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update windows ovs download link to ovs 2.16.7 #4705

Merged
merged 2 commits into from
May 8, 2023
Merged

Update windows ovs download link to ovs 2.16.7 #4705

merged 2 commits into from
May 8, 2023

Conversation

XinShuYang
Copy link
Contributor

Upgrade windows ovs to 2.16.7 on both script and CI testbeds.

Fixes #4702

@XinShuYang
Update windows ovs download link to ovs 2.16.7
caf5e68 
Upgrade windows ovs to 2.16.7 on both script and CI testbeds.

Fixes antrea-io#4702

Signed-off-by: Shuyang Xin <gavinx@vmware.com>
@XinShuYang
Copy link
Contributor Author

/test-windows-e2e
/test-windows-conformance
/test-windows-networkpolicy

@XinShuYang
Copy link
Contributor Author

/test-windows-containerd-e2e
/test-windows-containerd-conformance
/test-windows-containerd-networkpolicy

luolanzone
luolanzone reviewed Mar 16, 2023
View reviewed changes
hack/windows/Install-OVS.ps1
@@ -32,7 +32,7 @@ Param(
)

$ErrorActionPreference = "Stop"
$OVSDownloadURL = "https://downloads.antrea.io/ovs/ovs-2.15.2-antrea.0-win64.zip"
$OVSDownloadURL = "https://downloads.antrea.io/ovs/ovs-2.16.7-antrea.0-win64.zip"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am wondering how do we generate this OVS? anyway to check what we have in the download site?

Copy link
Contributor

@wenyingd wenyingd Mar 16, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to confirm if CI testbed also uses this OVS version or not.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes the testbed has been upgraded. I will run all windows CI jobs to verify new ovs.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any idea why it's v2.16.7 on Windows but not the same version as Linux? #4742

@XinShuYang
Copy link
Contributor Author

/test-windows-containerd-e2e
/test-windows-containerd-conformance
/test-windows-containerd-networkpolicy

@XinShuYang
Copy link
Contributor Author

/test-windows-containerd-e2e

@luolanzone luolanzone added the area/OS/windows Issues or PRs related to the Windows operating system. label Mar 17, 2023
@XinShuYang
Copy link
Contributor Author

/test-windows-containerd-e2e
/test-windows-containerd-conformance
/test-windows-containerd-networkpolicy

@codecov
Copy link

codecov bot commented Mar 17, 2023 •
edited
Loading

Codecov Report

Merging #4705 (0f9f333) into main (db426cc) will increase coverage by 1.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4705      +/-   ##
==========================================
+ Coverage   69.12%   70.22%   +1.09%     
==========================================
  Files         404      405       +1     
  Lines       59978    62109    +2131     
==========================================
+ Hits        41459    43613    +2154     
+ Misses      15696    15581     -115     
- Partials     2823     2915      +92
Flag Coverage Δ *Carryforward flag
e2e-tests 38.34% <ø> (ø) Carriedforward from caf5e68
integration-tests 33.96% <ø> (-0.49%) ⬇️
kind-e2e-tests 39.41% <ø> (-1.31%) ⬇️
unit-tests 62.15% <ø> (+1.61%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

see 59 files with indirect coverage changes

@XinShuYang
Copy link
Contributor Author

/test-windows-proxyall-e2e
/test-windows-containerd-conformance
/test-windows-containerd-networkpolicy

@XinShuYang
Copy link
Contributor Author

/test-windows-containerd-e2e
/test-windows-proxyall-e2e

@XinShuYang
Copy link
Contributor Author

/test-all
/test-windows-all

@XinShuYang
Copy link
Contributor Author

/test-windows-containerd-e2e

1 similar comment
@XinShuYang
Copy link
Contributor Author

/test-windows-containerd-e2e

@XinShuYang
Copy link
Contributor Author

/test-windows-containerd-e2e
/test-windows-containerd-conformance
/test-windows-containerd-networkpolicy

@XinShuYang
Copy link
Contributor Author

/test-windows-containerd-e2e

@XinShuYang
Copy link
Contributor Author

/test-windows-e2e
/test-windows-conformance
/test-windows-networkpolicy

@XinShuYang
Copy link
Contributor Author

/test-windows-e2e

@XinShuYang XinShuYang requested a review from tnqn April 17, 2023 11:25
@tnqn tnqn added the action/release-note Indicates a PR that should be included in release notes. label Apr 17, 2023
tnqn
tnqn reviewed Apr 17, 2023
View reviewed changes
test/e2e/nodeportlocal_test.go Outdated
node := nodeName(0)
workerNode := node
clientNode := nodeName(0)
workerNode := nodeName(1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clientNode and workerNode are named in different ways. I think clientNode and serverNode could express the intention more clearly.

test/e2e/nodeportlocal_test.go Outdated
@@ -405,9 +406,10 @@ func NPLTestMultiplePods(t *testing.T, data *TestData) {
func NPLTestPodAddMultiPort(t *testing.T, data *TestData) {
r := require.New(t)

node := nodeName(0)
clientNode := nodeName(0)
workerNode := nodeName(1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@XinShuYang
Copy link
Contributor Author

/test-all
/test-windows-all

@XinShuYang
Copy link
Contributor Author

/test-all
/test-windows-all

@XinShuYang
Copy link
Contributor Author

/test-e2e
/test-windows-e2e
/test-windows-containerd-e2e

tnqn
tnqn previously approved these changes Apr 19, 2023
View reviewed changes
Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XinShuYang
Update the topology of nodeportlocal e2e test
ccb6bc3 
The client and server pods should be on different nodes to be closed
to real scenarios and reduce unbalanced resources.

Signed-off-by: Shuyang Xin <gavinx@vmware.com>
@XinShuYang
Copy link
Contributor Author

/test-all
/test-windows-all

@XinShuYang
Copy link
Contributor Author

/test-windows-proxyall-e2e

@XinShuYang XinShuYang requested a review from tnqn April 23, 2023 01:49
@XinShuYang
Copy link
Contributor Author

/test-windows-containerd-conformance
/test-windows-containerd-networkpolicy

@XinShuYang
Copy link
Contributor Author

/test-windows-containerd-networkpolicy

4 similar comments
@XinShuYang
Copy link
Contributor Author

/test-windows-containerd-networkpolicy

@XinShuYang
Copy link
Contributor Author

/test-windows-containerd-networkpolicy

@XinShuYang
Copy link
Contributor Author

/test-windows-containerd-networkpolicy

@XinShuYang
Copy link
Contributor Author

/test-windows-containerd-networkpolicy

@luolanzone luolanzone added this to the Antrea v1.12 release milestone May 8, 2023
@luolanzone luolanzone mentioned this pull request May 8, 2023
Merged
@tnqn tnqn merged commit a5e2c25 into antrea-io:main May 8, 2023
ceclinux pushed a commit to ceclinux/antrea that referenced this pull request Jun 5, 2023
@XinShuYang @ceclinux
Update windows ovs download link to ovs 2.16.7 (antrea-io#4705)
aa8c044 
* Update windows ovs download link to ovs 2.16.7

Upgrade windows ovs to 2.16.7 on both script and CI testbeds.

Fixes antrea-io#4702

Signed-off-by: Shuyang Xin <gavinx@vmware.com>

* Update the topology of nodeportlocal e2e test

The client and server pods should be on different nodes to be closed
to real scenarios and reduce unbalanced resources.

Signed-off-by: Shuyang Xin <gavinx@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenyingd wenyingd wenyingd left review comments

@luolanzone luolanzone luolanzone left review comments

@tnqn tnqn tnqn approved these changes

Assignees
No one assigned
Labels
action/release-note Indicates a PR that should be included in release notes. area/OS/windows Issues or PRs related to the Windows operating system.
Projects
None yet
Milestone
Antrea v1.12 release
Development

Successfully merging this pull request may close these issues.

Windows Node fails to run Pod using the provided OVS binary
4 participants
@XinShuYang @wenyingd @tnqn @luolanzone