Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More uniform BGP router ID selection for IPv4 and IPv6 #6550

Closed
antoninbas opened this issue Jul 25, 2024 · 4 comments · Fixed by #6605
Closed

More uniform BGP router ID selection for IPv4 and IPv6 #6550

antoninbas opened this issue Jul 25, 2024 · 4 comments · Fixed by #6605
Assignees
Labels
area/transit/bgp Issues or PRs related to BGP support.

Comments

@antoninbas
Copy link
Contributor

Currently, the Node IP will be used as the BGP router ID unconditionally when the Node has an IPv4 address (IPv4-only or dual-stack clusters). For IPv6-only clusters, we will honor the node.antrea.io/bgp-router-id Node annotation (if provided by the user), or fallback to a "randomly-generated" value (in reality, hash-based).

This implementation doesn't make much sense to me. I see no reason why the annotation should not be honored in the IPv4 case. If anything, that just creates confusion. RFC 6286 relaxes the definition of the BGP router ID, and I don't think we need to "force" the ID to be the Node IP in the IPv4 case.

Originally posted by @antoninbas in #6524 (comment)

@antoninbas antoninbas added the area/transit/bgp Issues or PRs related to BGP support. label Jul 25, 2024
@antoninbas antoninbas added this to the Antrea v2.2 release milestone Jul 26, 2024
@rajnkamr
Copy link
Contributor

Originally, the BGP Identifier needed to be a unique identifier for each BGP router. Typically, it was derived from the IP address of the router i.e Node IP and the identifier had to be unique across the entire network,

However now it is defined as a 4-octet (32-bit), unsigned, non-zero integer.
Now Instead of requiring global uniqueness, the identifier only needs to be unique within the same Autonomous System (AS).

@rajnkamr rajnkamr added the action/release-note Indicates a PR that should be included in release notes. label Jul 29, 2024
@antoninbas antoninbas removed the action/release-note Indicates a PR that should be included in release notes. label Jul 31, 2024
@luolanzone

This comment was marked as off-topic.

@rajnkamr

This comment was marked as off-topic.

@antoninbas

This comment was marked as off-topic.

Atish-iaf added a commit to Atish-iaf/antrea that referenced this issue Aug 9, 2024
Fixes antrea-io#6550

Signed-off-by: Kumar Atish <kumar.atish@broadcom.com>
Atish-iaf added a commit to Atish-iaf/antrea that referenced this issue Aug 11, 2024
Fixes antrea-io#6550

Signed-off-by: Kumar Atish <kumar.atish@broadcom.com>
Atish-iaf added a commit to Atish-iaf/antrea that referenced this issue Aug 12, 2024
Fixes antrea-io#6550

Signed-off-by: Kumar Atish <kumar.atish@broadcom.com>
Atish-iaf added a commit to Atish-iaf/antrea that referenced this issue Aug 13, 2024
Fixes antrea-io#6550

Signed-off-by: Kumar Atish <kumar.atish@broadcom.com>
Atish-iaf added a commit to Atish-iaf/antrea that referenced this issue Aug 21, 2024
Fixes antrea-io#6550

Signed-off-by: Kumar Atish <kumar.atish@broadcom.com>
@tnqn tnqn closed this as completed in c76b38a Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/transit/bgp Issues or PRs related to BGP support.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants