feat(bear-tamer): bear tamer events

[antoinezanardi]

Summary by CodeRabbit

• New Features

  • Introduced a new component for bear events, enhancing visual representation of bear growling or sleeping.
  • Added new sound effect for "calm-bear-eating."
  • New translations for bear actions in English and French.
  • Added new scenarios for the "Bear Tamer" role, defining bear behavior based on game conditions.

• Bug Fixes

  • Removed outdated references to the "bear-tamer" role and related actions from game play and event management.

• Refactor

  • Consolidated imports for bear actions to streamline event handling and improve efficiency.

• Tests

  • Updated test cases to reflect the removal of "bear-tamer" related scenarios and added tests for the new bear event component.

[coderabbitai]

Walkthrough

This series of changes primarily centers on the game mechanics involving the "bear-tamer" role, simplifying event handling and consolidating components related to bear behaviors. The introduction of the GameBearGrowlsOrSleepsEvent enhances the narrative and gameplay experience. Additionally, various constants and translations have been updated to reflect these changes, resulting in a more streamlined interaction within the game.

Changes

File Path	Change Summary
.../GameOverHistoryRecordAction/GameOverHistoryRecordAction.vue	Simplified logic in computed property for game history actions, focusing only on "request-another-vote".
.../game-play/game-play.constants.ts	Removed "growl" action from the GAME_PLAY_ACTIONS constant.
.../GameBearGrowlsOrSleepsEvent/GameBearGrowlsOrSleepsEvent.vue	Introduced new component to represent bear events (growl/sleep) dynamically.
.../GameTurnStartsEvent/game-turn-starts-event.constants.ts	Removed mapping for "bear-tamer" from turn starts constants.
.../CurrentPlayQuestion/current-play-question.constants.ts	Removed entry for "bear-tamer" from game play questions.
.../i18n/locales/en.json	Added translations for bear event actions: "bearGrowls" and "bearSleeps".
.../i18n/locales/fr.json	Added French translations for "bearGrowls" and "bearSleeps".
.../audio/constants/audio.constants.ts	Introduced a new sound effect name, "calm-bear-eating".
tests/.../GameOverHistoryRecordAction/GameOverHistoryRecordAction.nuxt.spec.ts	Updated test cases, removing those related to "growl" and changing source name from "bear-tamer" to "witch".
tests/.../GameBearGrowlsOrSleepsEvent/GameBearGrowlsOrSleepsEvent.nuxt.spec.ts	New test file created for the GameBearGrowlsOrSleepsEvent component to validate functionality.
tests/.../game-play/game-play.factory.ts	Removed createFakeGamePlayBearTamerGrowls function from factory, reflecting changes in game play scenarios.

Poem

🐰 In the game where bears do roam,
Growls and sleeps have found a home.
The tamer's tales have changed their tune,
With new adventures coming soon!
Let’s cheer for changes, big and small,
For every bear, we'll have a ball! 🎉

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Outside diff range, codebase verification and nitpick comments (6)

app/components/pages/game/GameOver/GameOverHistory/GameOverHistoryRecords/GameOverHistoryRecord/GameOverHistoryRecordAction/GameOverHistoryRecordAction.vue (1)

47-49: Issue Found: The "growl" action is still referenced in the codebase.

The "growl" action appears in various parts of the codebase, including test files, components, and constants. Removing the condition for the "growl" action without ensuring it is handled appropriately elsewhere may lead to undefined behavior.

• File: tests/unit/specs/stores/audio/useAudioStore.spec.ts
• File: tests/unit/specs/components/pages/game/GamePlaying/GameEventsMonitor/GameEventsMonitorCurrentEvent/GameEventsMonitorCurrentEvent.nuxt.spec.ts
• File: tests/unit/specs/components/pages/game/GamePlaying/GameEventsMonitor/GameEventsMonitorCurrentEvent/GameBearGrowlsOrSleepsEvent/GameBearGrowlsOrSleepsEvent.nuxt.spec.ts
• File: app/stores/audio/constants/audio.constants.ts
• File: app/components/pages/game/GamePlaying/GameEventsMonitor/GameEventsMonitorCurrentEvent/GameEventsMonitorCurrentEvent.vue
• File: app/components/pages/game/GamePlaying/GameEventsMonitor/GameEventsMonitorCurrentEvent/GameBearGrowlsOrSleepsEvent/GameBearGrowlsOrSleepsEvent.vue
• File: app/components/pages/game-lobby/GameLobbyOptionsHub/GameLobbyOptionsHubTabView/GameLobbyOptionsHubRolesTab/GameLobbyOptionsHubRolesTabBearTamer/GameLobbyOptionsHubRolesTabBearTamer.vue
• File: app/composables/api/game/constants/game-event/game-event.constants.ts

Please review these references and ensure the "growl" action is handled appropriately.

Analysis chain

Verify the handling of the "growl" action.

The condition for the "growl" action has been removed. Ensure that the "growl" action is no longer needed or is handled appropriately elsewhere to avoid any undefined behavior.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the handling of the "growl" action in the codebase.

# Test: Search for references to the "growl" action. Expect: No remaining references or appropriate handling elsewhere.
rg --type python --type js --type ts --type vue -A 5 $'"growl"'

Length of output: 95

---

Script:

#!/bin/bash
# Description: Verify the handling of the "growl" action in the codebase.

# Test: Search for references to the "growl" action. Expect: No remaining references or appropriate handling elsewhere.
rg --type py --type js --type ts --type vue --type html -A 5 $'"growl"'

Length of output: 100

---

Script:

#!/bin/bash
# Description: Verify the handling of the "growl" action in the codebase.

# Test: Search for references to the "growl" action. Expect: No remaining references or appropriate handling elsewhere.
rg --type-add 'vue:*.vue' --type py --type js --type ts --type vue --type html -A 5 $'"growl"'

Length of output: 95

---

Script:

#!/bin/bash
# Description: Verify the handling of the "growl" action in the codebase.

# Test: Search for comments or documentation referencing the "growl" action. Expect: No remaining references.
rg --type-add 'vue:*.vue' --type md --type txt --type py --type js --type ts --type vue --type html -A 5 'growl'

Length of output: 33138

app/components/pages/game/GamePlaying/GamePlayground/CurrentPlayQuestion/current-play-question.constants.ts (1)

Incomplete removal of "bear-tamer" references.

The removal of the "bear-tamer" entry in current-play-question.constants.ts is not consistent with the rest of the codebase. There are still multiple references to "bear-tamer" in various files:

• tests/unit/specs/components/pages/game-lobby/GameLobbyOptionsHub/GameLobbyOptionsHubTabView/GameLobbyOptionsHubRolesTab/GameLobbyOptionsHubRolesTabBearTamer/GameLobbyOptionsHubRolesTabBearTamer.nuxt.spec.ts
• tests/unit/specs/components/pages/game/GamePlaying/GameEventsMonitor/GameEventsMonitorCurrentEvent/GameBearGrowlsOrSleepsEvent/GameBearGrowlsOrSleepsEvent.nuxt.spec.ts
• tests/unit/utils/factories/composables/api/game/player/player-with-role.factory.ts
• tests/unit/utils/factories/composables/api/game/game-options/roles-game-options/roles-game-options.factory.ts
• tests/unit/utils/factories/composables/api/game/game-options/roles-game-options/bear-tamer-game-options/bear-tamer-game-options.factory.ts
• tests/unit/specs/composables/api/game/game-options/roles-game-options/bear-tamer-game-options/bear-tamer-game-options.class.spec.ts
• app/stores/game/create-game-dto/useCreateGameDtoStore.ts
• app/components/pages/game-lobby/GameLobbyOptionsHub/GameLobbyOptionsHubTabView/GameLobbyOptionsHubRolesTab/GameLobbyOptionsHubRolesTabBearTamer/GameLobbyOptionsHubRolesTabBearTamer.vue
• app/components/pages/game/GamePlaying/GameEventsMonitor/GameEventsMonitorCurrentEvent/GameBearGrowlsOrSleepsEvent/GameBearGrowlsOrSleepsEvent.vue
• app/composables/api/game/types/game-options/roles-game-options/roles-game-options.class.ts
• app/composables/api/role/constants/role.constants.ts

Please review and ensure all references to "bear-tamer" are appropriately handled or removed.

Analysis chain

Line range hint 1-40:
Verify removal of all references to "bear-tamer".

Ensure that the removal of the "bear-tamer" entry is consistent and doesn't leave any dangling references in the codebase.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify that there are no dangling references to "bear-tamer" in the codebase.

# Test: Search for references to "bear-tamer". Expect: No occurrences.
rg --type js --type ts --type vue "bear-tamer"

Length of output: 74

---

Script:

#!/bin/bash
# Description: Verify that there are no dangling references to "bear-tamer" in the codebase.

# Test: Search for references to "bear-tamer". Expect: No occurrences.
rg --type js --type ts "bear-tamer"

Length of output: 4883

app/components/shared/game/game-play/game-play.constants.ts (1)

References to "bear-tamer" still exist in the codebase.

The removal of the "bear-tamer" entry from game-play.constants.ts is incomplete as there are still multiple references to "bear-tamer" across various files. These references need to be addressed to ensure consistency and avoid potential errors.

• tests/unit/specs/components/pages/game-lobby/GameLobbyOptionsHub/GameLobbyOptionsHubTabView/GameLobbyOptionsHubRolesTab/GameLobbyOptionsHubRolesTabBearTamer/GameLobbyOptionsHubRolesTabBearTamer.nuxt.spec.ts
• tests/unit/specs/components/pages/game/GamePlaying/GameEventsMonitor/GameEventsMonitorCurrentEvent/GameBearGrowlsOrSleepsEvent/GameBearGrowlsOrSleepsEvent.nuxt.spec.ts
• tests/unit/specs/composables/api/game/game-options/roles-game-options/bear-tamer-game-options/bear-tamer-game-options.class.spec.ts
• app/stores/game/create-game-dto/useCreateGameDtoStore.ts
• app/components/pages/game/GamePlaying/GameEventsMonitor/GameEventsMonitorCurrentEvent/GameBearGrowlsOrSleepsEvent/GameBearGrowlsOrSleepsEvent.vue
• app/composables/api/role/constants/role.constants.ts
• app/components/pages/game-lobby/GameLobbyOptionsHub/GameLobbyOptionsHubTabView/GameLobbyOptionsHubRolesTab/GameLobbyOptionsHubRolesTabBearTamer/GameLobbyOptionsHubRolesTabBearTamer.vue
• app/composables/api/game/types/game-options/roles-game-options/roles-game-options.class.ts
• tests/unit/utils/factories/composables/api/game/player/player-with-role.factory.ts
• tests/unit/utils/factories/composables/api/game/game-options/roles-game-options/roles-game-options.factory.ts
• tests/unit/utils/factories/composables/api/game/game-options/roles-game-options/bear-tamer-game-options/bear-tamer-game-options.factory.ts

Please review and update these references accordingly.

Analysis chain

Line range hint 1-40:
Verify removal of all references to "bear-tamer".

Ensure that the removal of the "bear-tamer" entry is consistent and doesn't leave any dangling references in the codebase.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify that there are no dangling references to "bear-tamer" in the codebase.

# Test: Search for references to "bear-tamer". Expect: No occurrences.
rg --type js --type ts --type vue "bear-tamer"

Length of output: 74

---

Script:

#!/bin/bash
# Description: Verify that there are no dangling references to "bear-tamer" in the codebase.

# Test: Search for references to "bear-tamer". Expect: No occurrences.
rg --type js --type ts "bear-tamer"

Length of output: 4883

app/components/pages/game/GamePlaying/GameEventsMonitor/GameEventsMonitorCurrentEvent/GameTurnStartsEvent/game-turn-starts-event.types.ts (1)

GameBearTamerTurnStartsEvent is still present in localization files.

The type GameBearTamerTurnStartsEvent was found in the following localization files:

• modules/i18n/locales/fr.json
• modules/i18n/locales/en.json

Please remove or update these references to ensure consistency across the codebase.

Analysis chain

Line range hint 27-52:
LGTM! But verify the removal of GameBearTamerTurnStartsEvent across the codebase.

The removal of GameBearTamerTurnStartsEvent from the union type is approved.

However, ensure that this type is no longer used elsewhere in the codebase.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify that `GameBearTamerTurnStartsEvent` is no longer used in the codebase.

# Test: Search for the usage of `GameBearTamerTurnStartsEvent`. Expect: No occurrences.
rg --type ts 'GameBearTamerTurnStartsEvent'

Length of output: 43

---

Script:

#!/bin/bash
# Description: Verify that `GameBearTamerTurnStartsEvent` is no longer used in the codebase.

# Test: Search for the usage of `GameBearTamerTurnStartsEvent` in all file types with additional context lines for better verification.
rg 'GameBearTamerTurnStartsEvent' -A 3 -B 3

Length of output: 1150

tests/unit/specs/stores/audio/useAudioStore.spec.ts (1)

33-33: The new audio file /audio/audio-backgrounds/night-2.webm is not used in the implementation.

The search results indicate that the audio file is only referenced in the test file but not in the actual application logic. Please ensure that the audio file is correctly integrated and used in the relevant parts of the implementation.

• app/stores/audio/useAudioStore.ts
• app/pages/game/[id].vue
• app/pages/game-lobby.vue

Analysis chain

Verify the new audio file addition.

Ensure that the new audio file /audio/audio-backgrounds/night-2.webm is correctly added and used in the codebase.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the usage of the new audio file `/audio/audio-backgrounds/night-2.webm`.

# Test: Search for the new audio file usage. Expect: At least one instance.
rg --type-add 'js:*.{js,jsx,ts,tsx}' --pcre2 '/audio/audio-backgrounds/night-2.webm'

Length of output: 9474

---

Script:

#!/bin/bash
# Description: Verify the usage of the new audio file `/audio/audio-backgrounds/night-2.webm` in the implementation files.

# Test: Search for the new audio file usage in the implementation files. Expect: At least one instance.
rg --type-add 'js:*.{js,jsx,ts,tsx}' --pcre2 '/audio/audio-backgrounds/night-2.webm' --glob '!tests/**' --glob '!stryker/**'

Length of output: 124

---

Script:

#!/bin/bash
# Description: Verify the inclusion of the new audio file `/audio/audio-backgrounds/night-2.webm` in the audio management or loading logic.

# Test: Search for audio file management or loading logic in the implementation files.
rg --type-add 'js:*.{js,jsx,ts,tsx}' --pcre2 'audio|sound' --glob '!tests/**' --glob '!stryker/**' -A 10

Length of output: 145245

app/composables/api/game/constants/game-play/game-play-source/game-play-source.constants.ts (1)

Address remaining references to bear-tamer

The bear-tamer entry has been removed from the GAME_PLAY_SOURCE_NAMES constant. However, there are still multiple references to bear-tamer in the codebase which need to be addressed to avoid potential inconsistencies or errors. Please review and update the following locations:

• tests/unit/specs/components/pages/game/GamePlaying/GameEventsMonitor/GameEventsMonitorCurrentEvent/GameBearGrowlsOrSleepsEvent/GameBearGrowlsOrSleepsEvent.nuxt.spec.ts
• tests/unit/specs/components/pages/game-lobby/GameLobbyOptionsHub/GameLobbyOptionsHubTabView/GameLobbyOptionsHubRolesTab/GameLobbyOptionsHubRolesTabBearTamer/GameLobbyOptionsHubRolesTabBearTamer.nuxt.spec.ts
• tests/unit/specs/composables/api/game/game-options/roles-game-options/bear-tamer-game-options/bear-tamer-game-options.class.spec.ts
• tests/unit/utils/factories/composables/api/game/player/player-with-role.factory.ts
• tests/unit/utils/factories/composables/api/game/game-options/roles-game-options/roles-game-options.factory.ts
• tests/unit/utils/factories/composables/api/game/game-options/roles-game-options/bear-tamer-game-options/bear-tamer-game-options.factory.ts
• app/components/pages/game/GamePlaying/GameEventsMonitor/GameEventsMonitorCurrentEvent/GameBearGrowlsOrSleepsEvent/GameBearGrowlsOrSleepsEvent.vue
• app/components/pages/game-lobby/GameLobbyOptionsHub/GameLobbyOptionsHubTabView/GameLobbyOptionsHubRolesTab/GameLobbyOptionsHubRolesTabBearTamer/GameLobbyOptionsHubRolesTabBearTamer.vue
• app/composables/api/role/constants/role.constants.ts
• app/stores/game/create-game-dto/useCreateGameDtoStore.ts
• app/composables/api/game/types/game-options/roles-game-options/roles-game-options.class.ts

Analysis chain

Line range hint 4-29:
Verify the removal of the bear-tamer entry.

The bear-tamer entry has been removed from the GAME_PLAY_SOURCE_NAMES constant. Ensure that this change does not break any game logic or references to the bear-tamer role elsewhere in the codebase.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify that the removal of the `bear-tamer` entry does not break any game logic or references.

# Test: Search for references to `bear-tamer` in the codebase. Expect: No broken references or errors.
rg --type js --type ts 'bear-tamer'

Length of output: 4883

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 9653815 and 24320d1.

Files ignored due to path filters (6)

• public/audio/sound-effects/calm-bear-eating.webm is excluded by !**/*.webm
• public/audio/sound-effects/thunder.mp3 is excluded by !**/*.mp3
• public/svg/role/angry-bear.svg is excluded by !**/*.svg
• public/svg/role/cool-bear.svg is excluded by !**/*.svg
• tests/unit/specs/components/pages/game/GamePlaying/GameEventsMonitor/GameEventsMonitorCurrentEvent/GameBearGrowlsOrSleepsEvent/__snapshots__/GameBearGrowlsOrSleepsEvent.nuxt.spec.ts.snap is excluded by !**/*.snap
• tests/unit/specs/components/pages/game/GamePlaying/GameEventsMonitor/GameEventsMonitorCurrentEvent/GameTurnStartsEvent/GameBearTamerTurnStartsEvent/__snapshots__/GameBearTamerTurnStartsEvent.nuxt.spec.ts.snap is excluded by !**/*.snap

Files selected for processing (23)

• app/components/pages/game/GameOver/GameOverHistory/GameOverHistoryRecords/GameOverHistoryRecord/GameOverHistoryRecordAction/GameOverHistoryRecordAction.vue (1 hunks)
• app/components/pages/game/GameOver/GameOverHistory/GameOverHistoryRecords/GameOverHistoryRecord/GameOverHistoryRecordAction/game-over-history-record-action.constants.ts (1 hunks)
• app/components/pages/game/GamePlaying/GameEventsMonitor/GameEventsMonitorCurrentEvent/GameBearGrowlsOrSleepsEvent/GameBearGrowlsOrSleepsEvent.vue (1 hunks)
• app/components/pages/game/GamePlaying/GameEventsMonitor/GameEventsMonitorCurrentEvent/GameEventsMonitorCurrentEvent.vue (2 hunks)
• app/components/pages/game/GamePlaying/GameEventsMonitor/GameEventsMonitorCurrentEvent/GameTurnStartsEvent/game-turn-starts-event.constants.ts (2 hunks)
• app/components/pages/game/GamePlaying/GameEventsMonitor/GameEventsMonitorCurrentEvent/GameTurnStartsEvent/game-turn-starts-event.types.ts (2 hunks)
• app/components/pages/game/GamePlaying/GamePlayground/CurrentPlayQuestion/current-play-question.constants.ts (1 hunks)
• app/components/shared/game/game-play/game-play.constants.ts (1 hunks)
• app/composables/api/game/constants/game-play/game-play-source/game-play-source.constants.ts (1 hunks)
• app/composables/api/game/constants/game-play/game-play.constants.ts (1 hunks)
• app/stores/audio/constants/audio.constants.ts (1 hunks)
• modules/i18n/locales/en.json (1 hunks)
• modules/i18n/locales/fr.json (1 hunks)
• tests/unit/specs/components/pages/game/GameOver/GameOverHistory/GameOverHistoryRecords/GameOverHistoryRecord/GameOverHistoryRecord.nuxt.spec.ts (1 hunks)
• tests/unit/specs/components/pages/game/GameOver/GameOverHistory/GameOverHistoryRecords/GameOverHistoryRecord/GameOverHistoryRecordAction/GameOverHistoryRecordAction.nuxt.spec.ts (3 hunks)
• tests/unit/specs/components/pages/game/GameOver/GameOverHistory/GameOverHistoryRecords/GameOverHistoryRecord/GameOverHistoryRecordDecision/GameOverHistoryRecordDecision.nuxt.spec.ts (1 hunks)
• tests/unit/specs/components/pages/game/GamePlaying/GameEventsMonitor/GameEventsMonitorCurrentEvent/GameBearGrowlsOrSleepsEvent/GameBearGrowlsOrSleepsEvent.nuxt.spec.ts (1 hunks)
• tests/unit/specs/components/pages/game/GamePlaying/GameEventsMonitor/GameEventsMonitorCurrentEvent/GameEventsMonitorCurrentEvent.nuxt.spec.ts (2 hunks)
• tests/unit/specs/components/pages/game/GamePlaying/GameEventsMonitor/GameEventsMonitorCurrentEvent/GameTurnStartsEvent/GameTurnStartsEvent.nuxt.spec.ts (3 hunks)
• tests/unit/specs/components/pages/game/GamePlaying/GamePlayground/CurrentPlayQuestion/CurrentPlayQuestion.nuxt.spec.ts (2 hunks)
• tests/unit/specs/components/pages/game/GamePlaying/GamePlayground/GamePlaygroundHeader/GamePlaygroundHeaderCurrentPlay/GamePlaygroundHeaderCurrentPlay.nuxt.spec.ts (3 hunks)
• tests/unit/specs/stores/audio/useAudioStore.spec.ts (2 hunks)
• tests/unit/utils/factories/composables/api/game/game-play/game-play.factory.ts (2 hunks)

Files skipped from review due to trivial changes (7)

• app/components/pages/game/GameOver/GameOverHistory/GameOverHistoryRecords/GameOverHistoryRecord/GameOverHistoryRecordAction/game-over-history-record-action.constants.ts
• app/components/pages/game/GamePlaying/GameEventsMonitor/GameEventsMonitorCurrentEvent/GameTurnStartsEvent/game-turn-starts-event.constants.ts
• app/composables/api/game/constants/game-play/game-play.constants.ts
• app/stores/audio/constants/audio.constants.ts
• tests/unit/specs/components/pages/game/GameOver/GameOverHistory/GameOverHistoryRecords/GameOverHistoryRecord/GameOverHistoryRecordAction/GameOverHistoryRecordAction.nuxt.spec.ts
• tests/unit/specs/components/pages/game/GamePlaying/GameEventsMonitor/GameEventsMonitorCurrentEvent/GameTurnStartsEvent/GameTurnStartsEvent.nuxt.spec.ts
• tests/unit/utils/factories/composables/api/game/game-play/game-play.factory.ts

Additional comments not posted (28)

app/components/pages/game/GamePlaying/GameEventsMonitor/GameEventsMonitorCurrentEvent/GameBearGrowlsOrSleepsEvent/GameBearGrowlsOrSleepsEvent.vue (2)

1-14: Template section looks good.

The template section is well-structured and utilizes existing components effectively.

---

16-54: Script setup section looks good.

The script setup section is correctly importing necessary components and stores, defining props, and computing values based on the event type. The logic for playing sound effects is also appropriately handled.

tests/unit/specs/components/pages/game/GamePlaying/GameEventsMonitor/GameEventsMonitorCurrentEvent/GameBearGrowlsOrSleepsEvent/GameBearGrowlsOrSleepsEvent.nuxt.spec.ts (10)

1-4: Import statements look good.

The import statements are well-organized and necessary for the test cases.

---

16-21: Default props look good.

The defaultProps are well-defined and cover the basic scenario for the event.

---

24-30: Component mounting function is well-defined.

The mountGameBearGrowlsOrSleepsEventComponent function is well-defined and allows for flexible component mounting with different options.

---

32-34: Setup before each test looks good.

The beforeEach hook ensures that the component is mounted before each test.

---

36-39: Snapshot test for rendering looks good.

The snapshot test ensures that the component renders correctly.

---

41-46: Snapshot test without shallow rendering looks good.

The snapshot test ensures that the component renders correctly without shallow rendering.

---

48-67: Sound effect tests look good.

The tests ensure that the correct sound effects are played for different event types.

---

70-93: Game event text tests look good.

The tests ensure that the correct texts are passed for different event types.

---

95-127: Event flipping players card tests look good.

The tests ensure that the correct SVG icon paths are passed for different event types.

---

12-15: Ensure comprehensive player data.

The defaultBearTamerPlayer is created with minimal data. Ensure that all necessary player attributes are included for comprehensive testing.

Verification successful

---

The createFakeBearTamerAlivePlayer function includes all necessary player attributes for comprehensive testing. The function sets default values for _id, name, role, side, attributes, and isAlive if they are not provided, ensuring comprehensive player data.

• createFakeBearTamerAlivePlayer sets the side attribute and spreads the rest of the player object.
• createFakeAlivePlayerWithRole sets the role and isAlive attributes and spreads the rest of the player object.
• createFakePlayer sets default values for _id, name, role, side, attributes, and isAlive if they are not provided.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify that `createFakeBearTamerAlivePlayer` includes all necessary player attributes.

# Test: Search for the function definition. Expect: Comprehensive player attributes.
rg --type js --type ts "createFakeBearTamerAlivePlayer"

Length of output: 868

---

Script:

#!/bin/bash
# Extract the implementation of the `createFakeBearTamerAlivePlayer` function to verify included attributes.
ast-grep --lang typescript --pattern 'function createFakeBearTamerAlivePlayer($_) { $$$ }'

Length of output: 92

---

Script:

#!/bin/bash
# Search for the `createFakeBearTamerAlivePlayer` function definition and include lines of context to display its implementation.
rg --type ts "function createFakeBearTamerAlivePlayer" -A 20

Length of output: 2429

---

Script:

#!/bin/bash
# Search for the `createFakeAlivePlayerWithRole` function definition and include lines of context to display its implementation.
rg --type ts "function createFakeAlivePlayerWithRole" -A 20

Length of output: 2342

---

Script:

#!/bin/bash
# Search for the `createFakePlayer` function definition and include lines of context to display its implementation.
rg --type ts "function createFakePlayer" -A 20

Length of output: 8186

app/components/pages/game/GamePlaying/GameEventsMonitor/GameEventsMonitorCurrentEvent/GameEventsMonitorCurrentEvent.vue (2)

27-27: LGTM!

The import statement for GameBearGrowlsOrSleepsEvent is correct.

---

67-68: LGTM!

The event type mappings for bear-growls and bear-sleeps are correctly updated to use GameBearGrowlsOrSleepsEvent.

tests/unit/specs/components/pages/game/GameOver/GameOverHistory/GameOverHistoryRecords/GameOverHistoryRecord/GameOverHistoryRecord.nuxt.spec.ts (1)

49-49: LGTM!

The update to the action property within the play object is correct.

tests/unit/specs/stores/audio/useAudioStore.spec.ts (2)

38-38: Verify the new audio file addition.

Ensure that the new audio file /audio/audio-backgrounds/night-3.webm is correctly added and used in the codebase.

Verification successful

---

The new audio file /audio/audio-backgrounds/night-3.webm is correctly added and used in the codebase.

• The file is referenced in tests/unit/specs/stores/audio/useAudioStore.spec.ts and is used in the test cases to verify its integration.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the usage of the new audio file `/audio/audio-backgrounds/night-3.webm`.

# Test: Search for the new audio file usage. Expect: At least one instance.
rg --type-add 'js:*.{js,jsx,ts,tsx}' --pcre2 '/audio/audio-backgrounds/night-3.webm'

Length of output: 9474

---

24-24: Verify the increment in Howl call count.

Ensure that the increment from 45 to 46 accurately reflects the number of Howl instances created.

Verification successful

Investigate the context around Howl instantiations.

We need to understand the context in which Howl is instantiated to verify the call count accurately.

---

Count entries in SOUND_EFFECT_NAMES and BACKGROUND_AUDIO_NAMES.

We need to verify the number of entries in these arrays to ensure the Howl call count is correct.

---

Count the entries in SOUND_EFFECT_NAMES and BACKGROUND_AUDIO_NAMES.

We need to count the elements in these arrays to verify the total number of Howl instances.

---

The increment in Howl call count is verified.

The total number of Howl instances created (46) matches the expected call count in the test.

• SOUND_EFFECT_NAMES: 41 entries
• BACKGROUND_AUDIO_NAMES: 5 entries

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the number of `Howl` instances created in the codebase.

# Test: Search for `Howl` instantiation. Expect: 46 instances.
rg --type-add 'js:*.{js,jsx,ts,tsx}' --pcre2 --count-matches 'new Howl'

Length of output: 142

---

Script:

#!/bin/bash
# Description: Gather context around `Howl` instantiations.

# Get surrounding lines of code around `new Howl` instances.
rg --type-add 'js:*.{js,jsx,ts,tsx}' --pcre2 -A 5 -B 5 'new Howl'

Length of output: 5809

---

Script:

#!/bin/bash
# Description: Count entries in `SOUND_EFFECT_NAMES` and `BACKGROUND_AUDIO_NAMES`.

# Search for the definitions of `SOUND_EFFECT_NAMES` and `BACKGROUND_AUDIO_NAMES`.
rg --type-add 'js:*.{js,jsx,ts,tsx}' --pcre2 'const SOUND_EFFECT_NAMES|const BACKGROUND_AUDIO_NAMES' -A 10

Length of output: 1524

---

Script:

#!/bin/bash
# Description: Count entries in `SOUND_EFFECT_NAMES` and `BACKGROUND_AUDIO_NAMES`.

# Count the number of entries in `SOUND_EFFECT_NAMES`.
rg --type-add 'js:*.{js,jsx,ts,tsx}' --pcre2 'const SOUND_EFFECT_NAMES = \[' -A 100 | sed -n '/const SOUND_EFFECT_NAMES = \[/,/]/p' | grep -c '^[^/].*,$'

# Count the number of entries in `BACKGROUND_AUDIO_NAMES`.
rg --type-add 'js:*.{js,jsx,ts,tsx}' --pcre2 'const BACKGROUND_AUDIO_NAMES = \[' -A 100 | sed -n '/const BACKGROUND_AUDIO_NAMES = \[/,/]/p' | grep -c '^[^/].*,$'

Length of output: 324

tests/unit/specs/components/pages/game/GameOver/GameOverHistory/GameOverHistoryRecords/GameOverHistoryRecord/GameOverHistoryRecordDecision/GameOverHistoryRecordDecision.nuxt.spec.ts (1)

209-209: Verify the new action type.

Ensure that the new action type "meet-each-other" is correctly handled in the tests and the codebase.

tests/unit/specs/components/pages/game/GamePlaying/GamePlayground/CurrentPlayQuestion/CurrentPlayQuestion.nuxt.spec.ts (1)

8-8: Verify the removal of createFakeGamePlayBearTamerGrowls import.

Ensure that the removal of the createFakeGamePlayBearTamerGrowls import does not negatively impact the test coverage.

Verification successful

---

Verified the removal of createFakeGamePlayBearTamerGrowls import.

The function createFakeGamePlayBearTamerGrowls is not defined or referenced anywhere in the codebase, confirming that its removal does not negatively impact the test coverage.

• No instances of createFakeGamePlayBearTamerGrowls found in the codebase.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the removal of the `createFakeGamePlayBearTamerGrowls` import does not negatively impact the test coverage.

# Test: Search for the usage of `createFakeGamePlayBearTamerGrowls`. Expect: No instances.
rg --type-add 'js:*.{js,jsx,ts,tsx}' --pcre2 'createFakeGamePlayBearTamerGrowls'

Length of output: 80

---

Script:

#!/bin/bash
# Description: Verify the removal of the `createFakeGamePlayBearTamerGrowls` import does not negatively impact the test coverage.

# Test 1: Search for the definition of `createFakeGamePlayBearTamerGrowls`.
rg --type-add 'js:*.{js,jsx,ts,tsx}' --pcre2 'function createFakeGamePlayBearTamerGrowls'

# Test 2: Search for any references to `createFakeGamePlayBearTamerGrowls` in the codebase.
rg --type-add 'js:*.{js,jsx,ts,tsx}' --pcre2 'createFakeGamePlayBearTamerGrowls'

Length of output: 172

tests/unit/specs/components/pages/game/GamePlaying/GamePlayground/GamePlaygroundHeader/GamePlaygroundHeaderCurrentPlay/GamePlaygroundHeaderCurrentPlay.nuxt.spec.ts (2)

9-9: LGTM! Import statement is comprehensive.

The import statement includes all necessary fake game play scenarios.

---

Line range hint 19-19:
LGTM! Ensure the removal of the "bear tamer growls" scenario is intentional.

The test cases for the current play SVG icon are well-structured and relevant.

Verification successful

---

LGTM! The "bear tamer growls" scenario has been successfully removed from the GamePlaygroundHeaderCurrentPlay.nuxt.spec.ts file.

• The test cases for the current play SVG icon are well-structured and relevant.
• The "bear tamer growls" scenario still exists in another test file, indicating it was moved or remains relevant in a different context.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the removal of the "bear tamer growls" scenario from the test cases.

# Test: Search for the "bear tamer growls" scenario in the test cases. Expect: No occurrences.
rg --type ts -A 5 $'bear tamer growls'

Length of output: 1520

---

Script:

#!/bin/bash
# Description: Verify the content of the file `GamePlaygroundHeaderCurrentPlay.nuxt.spec.ts` to confirm the removal of the "bear tamer growls" scenario.

# Test: Search for any occurrences of "bear tamer growls" in the specific file. Expect: No occurrences.
rg 'bear tamer growls' tests/unit/specs/components/pages/game/GamePlaying/GamePlayground/GamePlaygroundHeader/GamePlaygroundHeaderCurrentPlay/GamePlaygroundHeaderCurrentPlay.nuxt.spec.ts

Length of output: 188

tests/unit/specs/components/pages/game/GamePlaying/GameEventsMonitor/GameEventsMonitorCurrentEvent/GameEventsMonitorCurrentEvent.nuxt.spec.ts (3)

8-8: LGTM! Import statement is updated correctly.

The import statement for GameBearGrowlsOrSleepsEvent is relevant to the updated test cases.

---

233-240: LGTM! Test case is updated correctly.

The test case for the bear growls event is correctly updated to check for the GameBearGrowlsOrSleepsEvent component.

---

245-252: LGTM! Test case is updated correctly.

The test case for the bear sleeps event is correctly updated to check for the GameBearGrowlsOrSleepsEvent component.

modules/i18n/locales/en.json (2)

1450-1450: Translation addition approved: "bearGrowls".

The translation for "bearGrowls" is clear and contextually appropriate.

---

1451-1451: Translation addition approved: "bearSleeps".

The translation for "bearSleeps" is clear and contextually appropriate.

modules/i18n/locales/fr.json (2)

1450-1450: Translation looks good! Verify the context.

The translation for "bearGrowls" appears correct:

• French: "L'ours grogne ! Un ou plusieurs Loups-Garous se trouvent à juste à côté du Montreur d'Ours…"
• English: "The bear growls! One or more Werewolves are right next to the Bear Tamer…"

Ensure that this translation fits the intended context in the game.

---

1451-1451: Translation looks good! Verify the context.

The translation for "bearSleeps" appears correct:

• French: "L'ours mange paisiblement son miel. Aucun Loup-Garou n'est juste à côté du Montreur d'Ours…"
• English: "The bear is peacefully eating its honey. No Werewolves are right next to the Bear Tamer…"

Ensure that this translation fits the intended context in the game.

[coderabbitai]

Actionable comments posted: 0

Outside diff range, codebase verification and nitpick comments (1)

tests/acceptance/features/game/step-definitions/game-options/game-options.given-steps.ts (1)

203-207: Consider adding a comment to explain the purpose of this step.

Adding a comment would improve code readability and maintainability.

+ // This step prevents the bear from growling if infected in the game options.
Given(/^the user prevents bear to growl if he's infected in game options$/u, async function(this: CustomWorld): Promise<void> {
  await goOnPage(this, "/game-lobby");
  await openGameOptionsDialogInGameLobby(this);
  await switchRoleOptionInGameOptionsHub(this, "#game-lobby-options-hub-roles-tab-bear-tamer-does-growl-on-werewolves-side-input", false);
  await closeDialogWithHeaderButton(this);
});

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 24320d1 and 12b9042.

Files selected for processing (4)

• .run/Bear Tamer Role.run.xml (1 hunks)
• tests/acceptance/features/game/features/role/accursed-wolf-father.feature (1 hunks)
• tests/acceptance/features/game/features/role/bear-tamer.feature (1 hunks)
• tests/acceptance/features/game/step-definitions/game-options/game-options.given-steps.ts (1 hunks)

Additional comments not posted (26)

.run/Bear Tamer Role.run.xml (6)

3-3: Verify the correctness of the file path.

Ensure that the directory $PROJECT_DIR$/tests/acceptance exists and is the correct location for the acceptance tests.

---

4-4: LGTM!

The name filter is intentionally set to an empty string, likely to include all names.

---

5-5: Verify the correctness of the config file path and arguments.

Ensure that the config file config/cucumber/cucumber.json exists and the arguments --parallel 1 --tags @bear-tamer-role are appropriate for the test execution.

---

6-6: LGTM!

The working directory is correctly set to $PROJECT_DIR$.

---

8-8: Verify the necessity and correctness of the environment variable.

Ensure that the environment variable NODE_OPTIONS set to --import tsx/esm is necessary and correctly configured for the test execution.

---

10-10: LGTM!

The method version is correctly set to v="2".

tests/acceptance/features/game/features/role/accursed-wolf-father.feature (1)

61-61: LGTM!

The new assertion correctly verifies that the player with name "Antoine" is in the werewolves side in the game.

tests/acceptance/features/game/features/role/bear-tamer.feature (19)

1-3: LGTM!

The scenario "Bear growls only if there is a werewolf right next to its tamer" is correctly defined.

---

6-6: LGTM!

The step to disable the sheriff in game options is correctly defined.

---

7-13: LGTM!

The step to create a game with the specified players and roles is correctly defined.

---

14-16: LGTM!

The steps to close the toast and skip all game events are correctly defined.

---

18-20: LGTM!

The steps to have the werewolves eat the player "Bob" and verify that "Bob" is alive are correctly defined.

---

21-24: LGTM!

The steps to skip the game event and verify that the bear is calm and the event player card is "Antoine" are correctly defined.

---

25-27: LGTM!

The steps to skip all game events and verify the current play title is "Survivors vote" are correctly defined.

---

28-31: LGTM!

The steps to skip turns and verify the current play title is "Werewolves eat" are correctly defined.

---

32-34: LGTM!

The steps to have the werewolves eat the player "David" and verify that "David" is dead are correctly defined.

---

35-39: LGTM!

The steps to skip game events, verify the bear growling behavior, and check the event player card are correctly defined.

---

40-42: LGTM!

The steps to skip all game events and verify the current play title is "Survivors vote" are correctly defined.

---

43-55: LGTM!

The scenario "Bear growls even if there is no werewolf next to him when he's infected" and the initial steps are correctly defined.

---

56-59: LGTM!

The steps to have the werewolves eat the player "Antoine" and verify the current play title is "Accursed Wolf-Father infects" are correctly defined.

---

60-63: LGTM!

The steps to have the accursed wolf father infect the player "Antoine" and verify that "Antoine" is alive and in the werewolves side are correctly defined.

---

64-66: LGTM!

The steps to skip game events and verify the bear growling behavior are correctly defined.

---

68-81: LGTM!

The scenario "Bear doesn't growl even he's infected when game master prevents it in game options" and the initial steps are correctly defined.

---

82-85: LGTM!

The steps to have the werewolves eat the player "Antoine" and verify the current play title is "Accursed Wolf-Father infects" are correctly defined.

---

86-89: LGTM!

The steps to have the accursed wolf father infect the player "Antoine" and verify that "Antoine" is alive and in the werewolves side are correctly defined.

---

90-92: LGTM!

The steps to skip game events and verify the bear is calm are correctly defined.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[antoinezanardi]

🎉 This PR is included in version 1.27.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀